components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: null-check UrlRequest.Builder() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java

index 9922a129c4711daa364b7d5bd9d65215cddf0ed0..30f81476730a54d24d8c53c867646ab0022ea36e 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java

@@ -26,9 +26,9 @@ public class HistogramManagerTest extends CronetTestBase {

byte delta1[] = mActivity.mHistogramManager.getHistogramDeltas();

TestUrlRequestListener listener = new TestUrlRequestListener();

- UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(

- TEST_URL, listener, listener.getExecutor());

- urlRequest.start();

+ UrlRequest.Builder builder = new UrlRequest.Builder(

+ TEST_URL, listener, listener.getExecutor(), mActivity.mCronetEngine);

+ builder.build().start();

listener.blockForDone();

byte delta2[] = mActivity.mHistogramManager.getHistogramDeltas();

assertTrue(delta2.length != 0);