components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: null-check UrlRequest.Builder() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('K') | « components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java

index 439ea5127989deaab3f453d4a7f0c5017908905e..294ce199f66d275a6a57e2e0287eb692feddd634 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java

@@ -138,11 +138,11 @@ public class ContextInitTest extends CronetTestBase {

// crashes like crbug.com/453845

final CronetTestActivity activity = launchCronetTestApp();

HttpUrlRequestFactory firstFactory =

- HttpUrlRequestFactory.createFactory(activity, activity.getContextConfig());

+ HttpUrlRequestFactory.createFactory(activity.createCronetEngineBuilder(activity));

HttpUrlRequestFactory secondFactory = HttpUrlRequestFactory.createFactory(

- activity.getApplicationContext(), activity.getContextConfig());

+ activity.createCronetEngineBuilder(activity.getApplicationContext()));

HttpUrlRequestFactory thirdFactory = HttpUrlRequestFactory.createFactory(

- new ContextWrapper(activity), activity.getContextConfig());

+ activity.createCronetEngineBuilder(new ContextWrapper(activity)));

// Meager attempt to extend lifetimes to ensure they're concurrently

// alive.

firstFactory.getName();