Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: null-check UrlRequest.Builder() Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java b/components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
index 9894ecd6fb7a676eadb60c79bb0786a2fd37fe32..dd887a073a28ad2e1a486ebb130fca751ea258db 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
@@ -25,13 +25,12 @@ class CronetLibraryLoader {
* Ensure that native library is loaded and initialized. Can be called from
* any thread, the load and initialization is performed on main thread.
*/
- public static void ensureInitialized(
- final Context context, final UrlRequestContextConfig config) {
+ public static void ensureInitialized(final CronetEngine.Builder builder) {
synchronized (sLoadLock) {
if (sInitTaskPosted) {
return;
}
- System.loadLibrary(config.libraryName());
+ System.loadLibrary(builder.libraryName());
if (!Version.CRONET_VERSION.equals(nativeGetCronetVersion())) {
throw new RuntimeException(String.format(
"Expected Cronet version number %s, "
@@ -39,8 +38,9 @@ class CronetLibraryLoader {
Version.CRONET_VERSION,
nativeGetCronetVersion()));
}
+ final Context context = builder.getContext();
nativeCronetInitApplicationContext(context.getApplicationContext());
- // Init native Chromium URLRequestContext on Main UI thread.
+ // Init native Chromium CronetEngine on Main UI thread.
Runnable task = new Runnable() {
public void run() {
initOnMainThread(context);

Powered by Google App Engine
This is Rietveld 408576698