components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/HistogramManagerTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

index 7dbfbcadbe881d04041b11fe22f7a3ae21c4398f..c9c2006fcf776c4046c9d47e765c5b5677d0785f 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

@@ -67,12 +67,12 @@ public class HttpUrlRequestFactoryTest extends CronetTestBase {

@SmallTest

@Feature({"Cronet"})

- public void testCreateLegacyFactoryUsingUrlRequestContextConfig() {

- UrlRequestContextConfig config = new UrlRequestContextConfig();

- config.enableLegacyMode(true);

+ public void testCreateLegacyFactoryUsingCronetEngineBuilder() {

+ CronetEngine.Builder builder = new CronetEngine.Builder();

+ builder.enableLegacyMode(true);

HttpUrlRequestFactory factory = HttpUrlRequestFactory.createFactory(

- getInstrumentation().getTargetContext(), config);

+ getInstrumentation().getTargetContext(), builder);

assertNotNull("Factory should be created", factory);

assertTrue("Factory should be HttpUrlConnection/n.n.n.n@r but is "

+ factory.getName(),