[Cronet] Create Builders, rename UrlRequestContext to CronetEngine

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.ConditionVariable;
 import android.test.suitebuilder.annotation.SmallTest;
 import android.util.Pair;
 
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.TestUrlRequestListener.FailureType;
 import org.chromium.net.TestUrlRequestListener.ResponseStep;
 import org.chromium.net.test.FailurePhase;
 
 import java.nio.ByteBuffer;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 /**
  * Test functionality of CronetUrlRequest.
  */
 public class CronetUrlRequestTest extends CronetTestBase {
     // URL used for base tests.
     private static final String TEST_URL = "http://127.0.0.1:8000";
 
     private CronetTestActivity mActivity;
 
     @Override
     protected void setUp() throws Exception {
         super.setUp();
         mActivity = launchCronetTestApp();
         assertTrue(NativeTestServer.startNativeTestServer(
                 getInstrumentation().getTargetContext()));
         // Add url interceptors after native application context is initialized.
         MockUrlRequestJobFactory.setUp();
     }
 
     @Override
     protected void tearDown() throws Exception {
         NativeTestServer.shutdownNativeTestServer();
-        mActivity.mUrlRequestContext.shutdown();
+        mActivity.mCronetEngine.shutdown();
         super.tearDown();
     }
 
     private TestUrlRequestListener startAndWaitForComplete(String url)
             throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         // Create request.
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                url, listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(url, listener, listener.getExecutor());
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertTrue(urlRequest.isDone());
         return listener;
     }
 
     private void checkResponseInfo(ResponseInfo responseInfo,
             String expectedUrl, int expectedHttpStatusCode,
             String expectedHttpStatusText) {
         assertEquals(expectedUrl, responseInfo.getUrl());
         assertEquals(expectedUrl, responseInfo.getUrlChain()[
@@ skipping 32 matching lines @@
      * Tests a redirect by running it step-by-step. Also tests that delaying a
      * request works as expected. To make sure there are no unexpected pending
      * messages, does a GET between UrlRequestListener callbacks.
      */
     @SmallTest
     @Feature({"Cronet"})
     public void testRedirectAsync() throws Exception {
         // Start the request and wait to see the redirect.
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setAutoAdvance(false);
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectURL(), listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.waitForNextStep();
 
         // Check the redirect.
         assertEquals(ResponseStep.ON_RECEIVED_REDIRECT, listener.mResponseStep);
         assertEquals(1, listener.mRedirectResponseInfoList.size());
         checkResponseInfo(listener.mRedirectResponseInfoList.get(0),
                 NativeTestServer.getRedirectURL(), 302, "Found");
         assertEquals(1,
                 listener.mRedirectResponseInfoList.get(0).getUrlChain().length);
         assertEquals(NativeTestServer.getSuccessURL(), listener.mRedirectUrlList.get(0));
@@ skipping 87 matching lines @@
         // onFailed messages. This test relies on checks in
         // TestUrlRequestListener catching a second onFailed call.
         testSimpleGet();
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testSetHttpMethod() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         String methodName = "HEAD";
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoMethodURL(), listener,
-                listener.getExecutor());
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
         // Try to set 'null' method.
         try {
-            urlRequest.setHttpMethod(null);
+            builder.setHttpMethod(null);
             fail("Exception not thrown");
         } catch (NullPointerException e) {
             assertEquals("Method is required.", e.getMessage());
         }
 
-        urlRequest.setHttpMethod(methodName);
-        urlRequest.start();
-        try {
-            urlRequest.setHttpMethod("toolate");
-            fail("Exception not thrown");
-        } catch (IllegalStateException e) {
-            assertEquals("Request is already started.", e.getMessage());
-        }
+        builder.setHttpMethod(methodName);
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals(0, listener.mHttpResponseDataLength);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testBadMethod() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                TEST_URL, listener, listener.getExecutor());
+        UrlRequest.Builder builder =
+                new UrlRequest.Builder(TEST_URL, listener, listener.getExecutor());
         try {
-            urlRequest.setHttpMethod("bad:method!");
-            urlRequest.start();
+            builder.setHttpMethod("bad:method!");
+            mActivity.mCronetEngine.executeRequest(builder);
             fail("IllegalArgumentException not thrown.");
         } catch (IllegalArgumentException e) {
             assertEquals("Invalid http method bad:method!",
                     e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testBadHeaderName() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                TEST_URL, listener, listener.getExecutor());
+        UrlRequest.Builder builder =
+                new UrlRequest.Builder(TEST_URL, listener, listener.getExecutor());
         try {
-            urlRequest.addHeader("header:name", "headervalue");
-            urlRequest.start();
+            builder.addHeader("header:name", "headervalue");
+            mActivity.mCronetEngine.executeRequest(builder);
             fail("IllegalArgumentException not thrown.");
         } catch (IllegalArgumentException e) {
             assertEquals("Invalid header header:name=headervalue",
                     e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testBadHeaderValue() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                TEST_URL, listener, listener.getExecutor());
+        UrlRequest.Builder builder =
+                new UrlRequest.Builder(TEST_URL, listener, listener.getExecutor());
         try {
-            urlRequest.addHeader("headername", "bad header\r\nvalue");
-            urlRequest.start();
+            builder.addHeader("headername", "bad header\r\nvalue");
+            mActivity.mCronetEngine.executeRequest(builder);
             fail("IllegalArgumentException not thrown.");
         } catch (IllegalArgumentException e) {
             assertEquals("Invalid header headername=bad header\r\nvalue",
                     e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testAddHeader() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         String headerName = "header-name";
         String headerValue = "header-value";
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoHeaderURL(headerName), listener,
-                listener.getExecutor());
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoHeaderURL(headerName), listener, listener.getExecutor());
 
-        urlRequest.addHeader(headerName, headerValue);
-        urlRequest.start();
-        try {
-            urlRequest.addHeader("header2", "value");
-            fail("Exception not thrown");
-        } catch (IllegalStateException e) {
-            assertEquals("Request is already started.", e.getMessage());
-        }
+        builder.addHeader(headerName, headerValue);
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals(headerValue, listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testMultiRequestHeaders() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         String headerName = "header-name";
         String headerValue1 = "header-value1";
         String headerValue2 = "header-value2";
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoAllHeadersURL(), listener,
-                listener.getExecutor());
-        urlRequest.addHeader(headerName, headerValue1);
-        urlRequest.addHeader(headerName, headerValue2);
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoAllHeadersURL(), listener, listener.getExecutor());
+        builder.addHeader(headerName, headerValue1);
+        builder.addHeader(headerName, headerValue2);
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         String headers = listener.mResponseAsString;
         Pattern pattern = Pattern.compile(headerName + ":\\s(.*)\\r\\n");
         Matcher matcher = pattern.matcher(headers);
         List<String> actualValues = new ArrayList<String>();
         while (matcher.find()) {
             actualValues.add(matcher.group(1));
         }
         assertEquals(1, actualValues.size());
         assertEquals("header-value2", actualValues.get(0));
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testCustomUserAgent() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         String userAgentName = "User-Agent";
         String userAgentValue = "User-Agent-Value";
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoHeaderURL(userAgentName), listener,
-                listener.getExecutor());
-        urlRequest.addHeader(userAgentName, userAgentValue);
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoHeaderURL(userAgentName), listener, listener.getExecutor());
+        builder.addHeader(userAgentName, userAgentValue);
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals(userAgentValue, listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testDefaultUserAgent() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         String headerName = "User-Agent";
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoHeaderURL(headerName), listener,
-                listener.getExecutor());
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoHeaderURL(headerName), listener, listener.getExecutor());
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertTrue("Default User-Agent should contain Cronet/n.n.n.n but is "
                            + listener.mResponseAsString,
                    Pattern.matches(".+Cronet/\\d+\\.\\d+\\.\\d+\\.\\d+.+",
                            listener.mResponseAsString));
     }
 
     @SmallTest
     @Feature({"Cronet"})
@@ skipping 157 matching lines @@
      * when using legacy read() API.
      */
     @SmallTest
     @Feature({"Cronet"})
     public void testLegacySimpleGetBufferUpdates() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.mLegacyReadByteBufferAdjustment = true;
         listener.setAutoAdvance(false);
         // Since the default method is "GET", the expected response body is also
         // "GET".
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoMethodURL(),
-                listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.waitForNextStep();
 
         ByteBuffer readBuffer = ByteBuffer.allocateDirect(5);
         readBuffer.put("FOR".getBytes());
         assertEquals(3, readBuffer.position());
 
         // Read first two characters of the response ("GE"). It's theoretically
         // possible to need one read per character, though in practice,
         // shouldn't happen.
         while (listener.mResponseAsString.length() < 2) {
@@ skipping 63 matching lines @@
     /**
      * Checks that the buffer is updated correctly, when starting at an offset.
      */
     @SmallTest
     @Feature({"Cronet"})
     public void testSimpleGetBufferUpdates() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setAutoAdvance(false);
         // Since the default method is "GET", the expected response body is also
         // "GET".
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.waitForNextStep();
 
         ByteBuffer readBuffer = ByteBuffer.allocateDirect(5);
         readBuffer.put("FOR".getBytes());
         assertEquals(3, readBuffer.position());
 
         // Read first two characters of the response ("GE"). It's theoretically
         // possible to need one read per character, though in practice,
         // shouldn't happen.
         while (listener.mResponseAsString.length() < 2) {
@@ skipping 58 matching lines @@
         // Make sure there are no other pending messages, which would trigger
         // asserts in TestURLRequestListener.
         testSimpleGet();
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testBadBuffers() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setAutoAdvance(false);
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoMethodURL(), listener,
-                listener.getExecutor());
-        urlRequest.start();
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.waitForNextStep();
 
         // Try to read using a full buffer.
         try {
             ByteBuffer readBuffer = ByteBuffer.allocateDirect(4);
             readBuffer.put("full".getBytes());
             urlRequest.readNew(readBuffer);
             fail("Exception not thrown");
         } catch (IllegalArgumentException e) {
             assertEquals("ByteBuffer is already full.",
@@ skipping 17 matching lines @@
         listener.blockForDone();
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("GET", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUnexpectedReads() throws Exception {
         final TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setAutoAdvance(false);
-        final UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        final UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectURL(), listener, listener.getExecutor());
 
-        // Try to read before starting request.
-        try {
-            listener.startNextRead(urlRequest);
-            fail("Exception not thrown");
-        } catch (IllegalStateException e) {
-            assertEquals("Unexpected read attempt.",
-                    e.getMessage());
-        }
-
         // Verify reading right after start throws an assertion. Both must be
         // invoked on the Executor thread, to prevent receiving data until after
         // startNextRead has been invoked.
-        Runnable startAndRead = new Runnable() {
+        Callable<UrlRequest> startAndRead = new Callable<UrlRequest>() {
             @Override
-            public void run() {
-                urlRequest.start();
+            public UrlRequest call() {
+                UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
                 try {
                     listener.startNextRead(urlRequest);
                     fail("Exception not thrown");
                 } catch (IllegalStateException e) {
                     assertEquals("Unexpected read attempt.",
                             e.getMessage());
                 }
+                return urlRequest;
             }
         };
-        listener.getExecutor().execute(startAndRead);
+        Future<UrlRequest> future = listener.getExecutorService().submit(startAndRead);
         listener.waitForNextStep();
+        final UrlRequest urlRequest = future.get();
 
         assertEquals(listener.mResponseStep, ResponseStep.ON_RECEIVED_REDIRECT);
         // Try to read after the redirect.
         try {
             listener.startNextRead(urlRequest);
             fail("Exception not thrown");
         } catch (IllegalStateException e) {
             assertEquals("Unexpected read attempt.",
                     e.getMessage());
         }
@@ skipping 33 matching lines @@
             assertEquals("Unexpected read attempt.",
                     e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUnexpectedFollowRedirects() throws Exception {
         final TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setAutoAdvance(false);
-        final UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        final UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectURL(), listener, listener.getExecutor());
 
-        // Try to follow a redirect before starting the request.
-        try {
-            urlRequest.followRedirect();
-            fail("Exception not thrown");
-        } catch (IllegalStateException e) {
-            assertEquals("No redirect to follow.",
-                    e.getMessage());
-        }
-
         // Try to follow a redirect just after starting the request. Has to be
         // done on the executor thread to avoid a race.
-        Runnable startAndRead = new Runnable() {
+        Callable<UrlRequest> startAndRead = new Callable<UrlRequest>() {
             @Override
-            public void run() {
-                urlRequest.start();
+            public UrlRequest call() {
+                UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
                 try {
                     urlRequest.followRedirect();
                     fail("Exception not thrown");
                 } catch (IllegalStateException e) {
                     assertEquals("No redirect to follow.",
                             e.getMessage());
                 }
+                return urlRequest;
             }
         };
-        listener.getExecutor().execute(startAndRead);
+        Future<UrlRequest> future = listener.getExecutorService().submit(startAndRead);
         listener.waitForNextStep();
+        final UrlRequest urlRequest = future.get();

[mef, 2015/09/25 21:32:19]

why do you need it?

[pauljensen, 2015/09/28 14:18:12]

line 838, 840, 856, and 871 read it

[mef, 2015/09/28 17:13:37]

Ah, that's the pattern change, as we don't have request until executeRequest is
called.
I think this is another reason to follow Helen's suggestion and have an explicit
UrlRequest.Builder.build() method.

 
         assertEquals(listener.mResponseStep, ResponseStep.ON_RECEIVED_REDIRECT);
         // Try to follow the redirect twice. Second attempt should fail.
         Runnable followRedirectTwice = new Runnable() {
             @Override
             public void run() {
                 urlRequest.followRedirect();
                 try {
                     urlRequest.followRedirect();
                     fail("Exception not thrown");
@@ skipping 31 matching lines @@
         } catch (IllegalStateException e) {
             assertEquals("No redirect to follow.",
                     e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadSetDataProvider() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         try {
-            urlRequest.setUploadDataProvider(null, listener.getExecutor());
+            builder.setUploadDataProvider(null, listener.getExecutor());
             fail("Exception not thrown");
         } catch (NullPointerException e) {
             assertEquals("Invalid UploadDataProvider.", e.getMessage());
         }
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
         try {
-            urlRequest.start();
+            mActivity.mCronetEngine.executeRequest(builder);
             fail("Exception not thrown");
         } catch (IllegalArgumentException e) {
             assertEquals("Requests with upload data must have a Content-Type.", e.getMessage());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadEmptyBodySync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(0, dataProvider.getLength());
         assertEquals(0, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadSync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(4, dataProvider.getLength());
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("test", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadMultiplePiecesSync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("Y".getBytes());
         dataProvider.addRead("et ".getBytes());
         dataProvider.addRead("another ".getBytes());
         dataProvider.addRead("test".getBytes());
 
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(16, dataProvider.getLength());
         assertEquals(4, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("Yet another test", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadMultiplePiecesAsync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.ASYNC, listener.getExecutor());
         dataProvider.addRead("Y".getBytes());
         dataProvider.addRead("et ".getBytes());
         dataProvider.addRead("another ".getBytes());
         dataProvider.addRead("test".getBytes());
 
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(16, dataProvider.getLength());
         assertEquals(4, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("Yet another test", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadChangesDefaultMethod() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("POST", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadWithSetMethod() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoMethodURL(), listener, listener.getExecutor());
 
         final String method = "PUT";
-        urlRequest.setHttpMethod(method);
+        builder.setHttpMethod(method);
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("PUT", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadRedirectSync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         // 1 read call before the rewind, 1 after.
         assertEquals(2, dataProvider.getNumReadCalls());
         assertEquals(1, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("test", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadRedirectAsync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.ASYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         // 1 read call before the rewind, 1 after.
         assertEquals(2, dataProvider.getNumReadCalls());
         assertEquals(1, dataProvider.getNumRewindCalls());
 
         assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
         assertEquals("test", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadReadFailSync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.setReadFailure(0, TestUploadDataProvider.FailMode.CALLBACK_SYNC);
         // This will never be read, but if the length is 0, read may never be
         // called.
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Sync read failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadReadFailAsync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.setReadFailure(0, TestUploadDataProvider.FailMode.CALLBACK_ASYNC);
         // This will never be read, but if the length is 0, read may never be
         // called.
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Async read failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadReadFailThrown() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.setReadFailure(0, TestUploadDataProvider.FailMode.THROWN);
         // This will never be read, but if the length is 0, read may never be
         // called.
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(0, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Thrown read failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadRewindFailSync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.setRewindFailure(TestUploadDataProvider.FailMode.CALLBACK_SYNC);
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(1, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Sync rewind failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadRewindFailAsync() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.ASYNC, listener.getExecutor());
         dataProvider.setRewindFailure(TestUploadDataProvider.FailMode.CALLBACK_ASYNC);
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(1, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Async rewind failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadRewindFailThrown() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.setRewindFailure(TestUploadDataProvider.FailMode.THROWN);
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals(1, dataProvider.getNumRewindCalls());
 
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertEquals("Thrown rewind failure", listener.mError.getCause().getMessage());
         assertEquals(null, listener.mResponseInfo);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadChunked() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test hello".getBytes());
         dataProvider.setChunked(true);
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
 
         assertEquals(-1, dataProvider.getLength());
 
-        urlRequest.start();
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         // 1 read call for one data chunk.
         assertEquals(1, dataProvider.getNumReadCalls());
         assertEquals("test hello", listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadChunkedLastReadZeroLengthBody() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         // Add 3 reads. The last read has a 0-length body.
         dataProvider.addRead("hello there".getBytes());
         dataProvider.addRead("!".getBytes());
         dataProvider.addRead("".getBytes());
         dataProvider.setChunked(true);
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
 
         assertEquals(-1, dataProvider.getLength());
 
-        urlRequest.start();
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         // 2 read call for the first two data chunks, and 1 for final chunk.
         assertEquals(3, dataProvider.getNumReadCalls());
         assertEquals("hello there!", listener.mResponseAsString);
     }
 
     // Test where an upload fails without ever initializing the
     // UploadDataStream, because it can't connect to the server.
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadFailsWithoutInitializingStream() throws Exception {
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
         // Shut down the test server, so connecting to it fails. Note that
         // calling shutdown again during teardown is safe.
         NativeTestServer.shutdownNativeTestServer();
 
         TestUploadDataProvider dataProvider = new TestUploadDataProvider(
                 TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
         dataProvider.addRead("test".getBytes());
-        urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, listener.getExecutor());
+        builder.addHeader("Content-Type", "useless/string");
+        mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
 
         assertNull(listener.mResponseInfo);
         assertEquals("Exception in CronetUrlRequest: net::ERR_CONNECTION_REFUSED",
                 listener.mError.getMessage());
     }
 
     private void throwOrCancel(FailureType failureType, ResponseStep failureStep,
             boolean expectResponseInfo, boolean expectError) {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setFailure(failureType, failureStep);
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectURL(), listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(1, listener.mRedirectCount);
         assertEquals(listener.mResponseStep, failureStep);
         assertTrue(urlRequest.isDone());
         assertEquals(expectResponseInfo, listener.mResponseInfo != null);
         assertEquals(expectError, listener.mError != null);
         assertEquals(expectError, listener.mOnErrorCalled);
     }
 
     @SmallTest
@@ skipping 25 matching lines @@
                 true, false);
         throwOrCancel(FailureType.THROW_SYNC, ResponseStep.ON_READ_COMPLETED,
                 true, true);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testThrowON_SUCCEEDED() {
         TestUrlRequestListener listener = new TestUrlRequestListener();
         listener.setFailure(FailureType.THROW_SYNC, ResponseStep.ON_SUCCEEDED);
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getRedirectURL(), listener, listener.getExecutor());
-        urlRequest.start();
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         listener.blockForDone();
         assertEquals(1, listener.mRedirectCount);
         assertEquals(listener.mResponseStep, ResponseStep.ON_SUCCEEDED);
         assertTrue(urlRequest.isDone());
         assertNotNull(listener.mResponseInfo);
         assertNull(listener.mError);
         assertFalse(listener.mOnErrorCalled);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testExecutorShutdown() {
         TestUrlRequestListener listener = new TestUrlRequestListener();
 
         listener.setAutoAdvance(false);
+        UrlRequest.Builder builder = new UrlRequest.Builder(
+                NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
         CronetUrlRequest urlRequest =
-                (CronetUrlRequest) mActivity.mUrlRequestContext.createRequest(
-                NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
-        urlRequest.start();
+                (CronetUrlRequest) mActivity.mCronetEngine.executeRequest(builder);
         listener.waitForNextStep();
         assertFalse(listener.isDone());
         assertFalse(urlRequest.isDone());
 
         final ConditionVariable requestDestroyed = new ConditionVariable(false);
         urlRequest.setOnDestroyedCallbackForTests(new Runnable() {
             @Override
             public void run() {
                 requestDestroyed.open();
             }
@@ skipping 31 matching lines @@
                 mByteBuffer = byteBuffer;
                 mReadCalled.open();
             }
 
             @Override
             public void rewind(final UploadDataSink uploadDataSink) {
             }
         }
 
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest.Builder builder = new UrlRequest.Builder(
                 NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
 
         ExecutorService uploadExecutor = Executors.newSingleThreadExecutor();
         HangingUploadDataProvider dataProvider = new HangingUploadDataProvider();
-        urlRequest.setUploadDataProvider(dataProvider, uploadExecutor);
-        urlRequest.addHeader("Content-Type", "useless/string");
-        urlRequest.start();
+        builder.setUploadDataProvider(dataProvider, uploadExecutor);
+        builder.addHeader("Content-Type", "useless/string");
+        UrlRequest urlRequest = mActivity.mCronetEngine.executeRequest(builder);
         // Wait for read to be called on executor.
         dataProvider.mReadCalled.block();
         // Shutdown the executor, so posting next task will throw an exception.
         uploadExecutor.shutdown();
         // Continue the upload.
         dataProvider.mByteBuffer.putInt(42);
         dataProvider.mUploadDataSink.onReadSucceeded(false);
         // Listener.onFailed will be called on request executor even though upload
         // executor is shutdown.
         listener.blockForDone();
         assertTrue(listener.isDone());
         assertTrue(listener.mOnErrorCalled);
         assertEquals("Exception received from UploadDataProvider", listener.mError.getMessage());
         assertTrue(urlRequest.isDone());
     }
 
     // Returns the contents of byteBuffer, from its position() to its limit(),
     // as a String. Does not modify byteBuffer's position().
     private String bufferContentsToString(ByteBuffer byteBuffer, int start,
             int end) {
         // Use a duplicate to avoid modifying byteBuffer.
         ByteBuffer duplicate = byteBuffer.duplicate();
         duplicate.position(start);
         duplicate.limit(end);
         byte[] contents = new byte[duplicate.remaining()];
         duplicate.get(contents);
         return new String(contents);
     }
 }