tools/gn/bin/roll_gn.py - Issue 1363703003: Attempt to fix race in GN auto-roller again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/bin/roll_gn.py

Issue 1363703003: Attempt to fix race in GN auto-roller again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/bin/roll_gn.py

diff --git a/tools/gn/bin/roll_gn.py b/tools/gn/bin/roll_gn.py

index 6c29b0afbde0eddd85eeca8982a2986a1c5b9d32..f02ba8b67aac138d6d75c898b776cf5680b1a693 100644

--- a/tools/gn/bin/roll_gn.py

+++ b/tools/gn/bin/roll_gn.py

@@ -181,7 +181,7 @@ class GNRoller(object):

def WaitForBuildToFinish(self):

print('Checking build')

results = self.CheckBuild()

- while (len(results) or

+ while (len(results) < 3 or

any(r['state'] == 'pending' for r in results.values())):

print()

print('Sleeping for 30 seconds')

« no previous file with comments | « no previous file | no next file » | no next file with comments »