Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: cc/trees/layer_tree_host.cc

Issue 13637017: Delete layout_viewport_size. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host.cc
diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc
index 1dd29a934be5d8d23b8b55729183031e7d5996c2..17fd3364dc0af635cf7597134d8b746547ff38a6 100644
--- a/cc/trees/layer_tree_host.cc
+++ b/cc/trees/layer_tree_host.cc
@@ -37,6 +37,7 @@
#include "cc/trees/single_thread_proxy.h"
#include "cc/trees/thread_proxy.h"
#include "cc/trees/tree_synchronizer.h"
+#include "ui/gfx/size_conversions.h"
namespace {
static int s_num_layer_tree_instances;
@@ -342,7 +343,7 @@ void LayerTreeHost::FinishCommitOnImplThread(LayerTreeHostImpl* host_impl) {
max_page_scale_factor_);
sync_tree->SetPageScaleDelta(page_scale_delta / sent_page_scale_delta);
- host_impl->SetViewportSize(layout_viewport_size_, device_viewport_size_);
+ host_impl->SetViewportSize(device_viewport_size_);
host_impl->SetOverdrawBottomHeight(overdraw_bottom_height_);
host_impl->SetDeviceScaleFactor(device_scale_factor_);
host_impl->SetDebugState(debug_state_);
@@ -384,7 +385,8 @@ void LayerTreeHost::SetPinchZoomScrollbarsBoundsAndPosition() {
if (!pinch_zoom_scrollbar_horizontal_ || !pinch_zoom_scrollbar_vertical_)
return;
- gfx::Size size = layout_viewport_size();
+ gfx::Size size = gfx::ToCeiledSize(
+ gfx::ScaleSize(device_viewport_size(), 1 / device_scale_factor()));
danakj 2013/04/09 00:04:35 nit: 1.f
int track_width = PinchZoomScrollbarGeometry::kTrackWidth;
pinch_zoom_scrollbar_horizontal_->SetBounds(
@@ -623,13 +625,10 @@ void LayerTreeHost::SetDebugState(const LayerTreeDebugState& debug_state) {
SetNeedsCommit();
}
-void LayerTreeHost::SetViewportSize(gfx::Size layout_viewport_size,
- gfx::Size device_viewport_size) {
- if (layout_viewport_size == layout_viewport_size_ &&
- device_viewport_size == device_viewport_size_)
+void LayerTreeHost::SetViewportSize(gfx::Size device_viewport_size) {
+ if (device_viewport_size == device_viewport_size_)
return;
- layout_viewport_size_ = layout_viewport_size;
device_viewport_size_ = device_viewport_size;
SetPinchZoomScrollbarsBoundsAndPosition();
@@ -712,7 +711,7 @@ void LayerTreeHost::UpdateLayers(ResourceUpdateQueue* queue,
if (!root_layer())
return;
- if (layout_viewport_size().IsEmpty())
+ if (device_viewport_size().IsEmpty())
return;
if (memory_allocation_limit_bytes) {

Powered by Google App Engine
This is Rietveld 408576698