Fix font handles leak. We return without freeing resources.

src/ports/SkFontHost_win.cpp

Index: src/ports/SkFontHost_win.cpp
===================================================================
--- src/ports/SkFontHost_win.cpp	(revision 8437)
+++ src/ports/SkFontHost_win.cpp	(working copy)
@@ -1386,7 +1386,7 @@
         info->fStemV = 0;
         info->fCapHeight = 0;
         info->fBBox = SkIRect::MakeEmpty();
-        return info;
+        goto ReturnInfo;
     }
 
     // If this bit is clear the font is a fixed pitch font.
@@ -1453,6 +1453,7 @@
     }
 
 Error:

[Vitaly Buka (NO REVIEWS), 2013/04/06 19:33:43]

Why not just rename Error: -> Exit: or Return:

[edisonn, 2013/04/08 15:09:43]

this message was lost somehow:
I prefer ReturnInfo, so it is explicit what we return. I don't want someone else
to have some other variable they want to return instead.

Anyway, we should update this code with smart object that delete the object, so
we don't have this kind of issues, but I did not want to make a bug change and
potentially introduce another bug

On 2013/04/06 19:33:43, Vitaly Buka wrote:

+ReturnInfo:
     SelectObject(hdc, savefont);
     DeleteObject(designFont);
     DeleteObject(font);