Fix font handles leak. We return without freeing resources.

Fix font handles leak. We return without freeing resources.
Fix for crbug/225256
Committed: https://code.google.com/p/skia/source/detail?r=8549

[edisonn, 2013-04-06 13:39:58]

Please review ASAP.  This crash is a regression (hitting M26 and M27), and I
need to get it in then ported it to M26 and M27 ASAP.

[bungeman-skia, 2013-04-06 17:44:15]

On 2013/04/06 13:39:58, edisonn wrote:
> Please review ASAP.  This crash is a regression (hitting M26 and M27), and I
> need to get it in then ported it to M26 and M27 ASAP.

LGTM

Note that we should review the other impls of getAdvancedTypefaceMetrics as
well. I think some of them have already had this change made, but I'm not sure
this is the last one.

[Vitaly Buka (NO REVIEWS), 2013-04-06 19:33:43]

lgtm

https://codereview.chromium.org/13637004/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.chromium.org/13637004/diff/1/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:1455: Error:
Why not just rename Error: -> Exit: or Return:

[edisonn, 2013-04-06 20:26:26]

Committed patchset #1 manually as r8549 (presubmit successful).

[edisonn, 2013-04-08 15:09:43]

https://codereview.chromium.org/13637004/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.chromium.org/13637004/diff/1/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:1455: Error:
this message was lost somehow:
I prefer ReturnInfo, so it is explicit what we return. I don't want someone else
to have some other variable they want to return instead.

Anyway, we should update this code with smart object that delete the object, so
we don't have this kind of issues, but I did not want to make a bug change and
potentially introduce another bug

On 2013/04/06 19:33:43, Vitaly Buka wrote:
> Why not just rename Error: -> Exit: or Return: