Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Issue 1363673004: [DRP] Consistently use LoFi for an entire page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix experiment control header Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
index b3eefde99dfdcc8335d5f2bcd1eef762575c6d91..66367556b4da050ca315bbea881803c65e0014c0 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
@@ -43,6 +43,11 @@ bool IsIncludedInHoldbackFieldTrial();
// a promotion for the data reduction proxy on Android One devices.
bool IsIncludedInAndroidOnePromoFieldTrial(const char* build_fingerprint);
+// Returns true if this client has any of the the command line switches to
+// enable Lo-Fi mode. This includes the always on, cellular only, and slow
+// connections switches.
bengr 2015/10/12 21:06:41 These aren't separate switches, are they? You migh
megjablon 2015/10/12 23:08:05 Done.
+bool IsLoFiOnViaFlags();
+
// Returns true if this client has the command line switch to enable Lo-Fi
// mode always on.
bool IsLoFiAlwaysOnViaFlags();
@@ -78,6 +83,14 @@ std::string GetLoFiFieldTrialName();
// is force enabled through flags.
std::string GetLoFiFlagFieldTrialName();
+// Returns true if this client is part of Lo-Fi enabled field trial.
bengr 2015/10/12 21:06:41 ...is part of the "Enabled" group of the Lo-Fi fie
megjablon 2015/10/12 23:08:05 Done.
+// Virtualized for unit testing.
+bool IsIncludedInLoFiEnabledFieldTrial();
+
+// Returns true if this client is part of Lo-Fi control field trial.
bengr 2015/10/12 21:06:41 ...is part of the "Control" group of the Lo-Fi fie
megjablon 2015/10/12 23:08:05 Done.
+// Virtualized for unit testing.
+bool IsIncludedInLoFiControlFieldTrial();
+
std::string GetQuicFieldTrialName();
// Returns the name of the client config field trial.

Powered by Google App Engine
This is Rietveld 408576698