Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1363663004: stop scaling loops and improve warmup bench (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

stop scaling loops and improve warmup bench BUG=skia: Committed: https://skia.googlesource.com/skia/+/8db65a6d0c60d0e31eadc64d427f6e7f050e1140

Patch Set 1 #

Total comments: 1

Patch Set 2 : transparent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M bench/RectBench.cpp View 1 2 chunks +26 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 2 months ago (2015-09-24 19:25:55 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1363663004/diff/1/bench/RectBench.cpp File bench/RectBench.cpp (right): https://codereview.chromium.org/1363663004/diff/1/bench/RectBench.cpp#newcode117 bench/RectBench.cpp:117: class NonOpaqueRectBench : public RectBench { TransparentRectBench?
5 years, 2 months ago (2015-09-24 19:31:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363663004/20001
5 years, 2 months ago (2015-09-24 19:37:28 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 19:42:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8db65a6d0c60d0e31eadc64d427f6e7f050e1140

Powered by Google App Engine
This is Rietveld 408576698