TimelinePanel: rename _sidebarView to _recordsView

Source/devtools/front_end/TimelineView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 75 matching lines @@
     this._detailsSplitView.mainElement().classList.add("vbox");
     this._detailsSplitView.setMainElementConstraints(undefined, 40);
     this._detailsView = new WebInspector.TimelineDetailsView();
     this._detailsSplitView.setSidebarView(this._detailsView);
     this._detailsSplitView.installResizer(this._detailsView.titleElement());
 
     WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
     WebInspector.settings.splitVerticallyWhenDockedToRight.addChangeListener(this._dockSideChanged.bind(this));
     this._dockSideChanged();
 
-    // Create memory splitter as a left child of properties.
     this._searchableView = new WebInspector.SearchableView(this);
     this._detailsSplitView.setMainView(this._searchableView);
 
-    this._timelineMemorySplitter = new WebInspector.SplitView(false, "timeline-memory");
-    this._timelineMemorySplitter.element.classList.remove("fill");
-    this._timelineMemorySplitter.element.classList.add("timeline-memory-split");
-    this._timelineMemorySplitter.show(this._searchableView.element);
-
     // Create records sidebar as a top memory splitter child.
-    this._sidebarView = new WebInspector.SidebarView(WebInspector.SidebarView.SidebarPosition.Start, "timeline-split");
-    this._sidebarView.addEventListener(WebInspector.SidebarView.EventTypes.Resized, this._sidebarResized, this);
-    this._sidebarView.setSecondIsSidebar(false);
-    this._timelineMemorySplitter.setMainView(this._sidebarView);
-    this._containerElement = this._sidebarView.element;
+    this._recordsView = new WebInspector.SidebarView(WebInspector.SidebarView.SidebarPosition.Start, "timeline-split");
+    this._recordsView.addEventListener(WebInspector.SidebarView.EventTypes.Resized, this._sidebarResized, this);
+    this._recordsView.setSecondIsSidebar(false);
+    this._containerElement = this._recordsView.element;
     this._containerElement.tabIndex = 0;
     this._containerElement.id = "timeline-container";
     this._containerElement.addEventListener("scroll", this._onScroll.bind(this), false);
 
-    // Create memory statistics as a bottom memory splitter child.
-    this._memoryStatistics = new WebInspector.CountersGraph(this, this._model);
-    this._timelineMemorySplitter.setSidebarView(this._memoryStatistics);
-    this._timelineMemorySplitter.installResizer(this._memoryStatistics.resizeElement());
-
     // Create records list in the records sidebar.
-    this._sidebarView.sidebarElement().classList.add("vbox");
-    this._sidebarView.sidebarElement().createChild("div", "timeline-records-title").textContent = WebInspector.UIString("RECORDS");
-    this._sidebarListElement = this._sidebarView.sidebarElement().createChild("div", "timeline-records-list");
+    this._recordsView.sidebarElement().classList.add("vbox");
+    this._recordsView.sidebarElement().createChild("div", "timeline-records-title").textContent = WebInspector.UIString("RECORDS");
+    this._sidebarListElement = this._recordsView.sidebarElement().createChild("div", "timeline-records-list");
 
     // Create grid in the records main area.
     this._gridContainer = new WebInspector.ViewWithResizeCallback(this._onViewportResize.bind(this));
     this._gridContainer.element.classList.add("fill");
     this._gridContainer.element.id = "resources-container-content";
-    this._sidebarView.setMainView(this._gridContainer);
+    this._recordsView.setMainView(this._gridContainer);
     this._timelineGrid = new WebInspector.TimelineGrid();
     this._itemsGraphsElement = this._timelineGrid.itemsGraphsElement;
     this._itemsGraphsElement.id = "timeline-graphs";
     this._gridContainer.element.appendChild(this._timelineGrid.element);
     this._timelineGrid.gridHeaderElement.id = "timeline-grid-header";
     this._timelineGrid.gridHeaderElement.classList.add("fill");
-    this._memoryStatistics.setMainTimelineGrid(this._timelineGrid);
-    this._timelineMemorySplitter.mainElement().appendChild(this._timelineGrid.gridHeaderElement);
-    if (this._currentMode === WebInspector.TimelinePanel.Mode.Memory)
-        this._timelineMemorySplitter.showBoth();
-    else
-        this._timelineMemorySplitter.showOnlyFirst();
 
     // Create gap elements
     this._topGapElement = this._itemsGraphsElement.createChild("div", "timeline-gap");
     this._graphRowsElement = this._itemsGraphsElement.createChild("div");
     this._bottomGapElement = this._itemsGraphsElement.createChild("div", "timeline-gap");
     this._expandElements = this._itemsGraphsElement.createChild("div");
     this._expandElements.id = "orphan-expand-elements";
 
-    this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
-
-    this.element.addEventListener("mousemove", this._mouseMove.bind(this), false);
-    this.element.addEventListener("mouseout", this._mouseOut.bind(this), false);
-    this.element.addEventListener("keydown", this._keyDown.bind(this), false);
-
-    this._expandOffset = 15;
-
     // Create gpu tasks containers.
     this._mainThreadTasks = /** @type {!Array.<!TimelineAgent.TimelineEvent>} */ ([]);
     this._gpuTasks = /** @type {!Array.<!TimelineAgent.TimelineEvent>} */ ([]);
     var utilizationStripsElement = this._timelineGrid.gridHeaderElement.createChild("div", "timeline-utilization-strips vbox");
     this._cpuBarsElement = utilizationStripsElement.createChild("div", "timeline-utilization-strip");
     if (WebInspector.experimentsSettings.gpuTimeline.isEnabled())
         this._gpuBarsElement = utilizationStripsElement.createChild("div", "timeline-utilization-strip gpu");
 
+    // Create memory splitter as a left child of properties.

[pfeldman, 2014/01/13 12:49:02]

Why reordering?

+    this._timelineMemorySplitter = new WebInspector.SplitView(false, "timeline-memory");
+    this._timelineMemorySplitter.element.classList.remove("fill");
+    this._timelineMemorySplitter.element.classList.add("timeline-memory-split");
+    this._timelineMemorySplitter.show(this._searchableView.element);
+    this._timelineMemorySplitter.setMainView(this._recordsView);
+
+    // Create memory statistics as a bottom memory splitter child.
+    this._memoryStatistics = new WebInspector.CountersGraph(this, this._model);
+    this._timelineMemorySplitter.setSidebarView(this._memoryStatistics);
+    this._timelineMemorySplitter.installResizer(this._memoryStatistics.resizeElement());
+
+    this._memoryStatistics.setMainTimelineGrid(this._timelineGrid);
+    this._timelineMemorySplitter.mainElement().appendChild(this._timelineGrid.gridHeaderElement);
+    if (this._currentMode === WebInspector.TimelinePanel.Mode.Memory)
+        this._timelineMemorySplitter.showBoth();
+    else
+        this._timelineMemorySplitter.showOnlyFirst();
+
+    this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
+
+    this.element.addEventListener("mousemove", this._mouseMove.bind(this), false);
+    this.element.addEventListener("mouseout", this._mouseOut.bind(this), false);
+    this.element.addEventListener("keydown", this._keyDown.bind(this), false);
+
+    this._expandOffset = 15;
+
     this._windowStartTime = 0;
     this._windowEndTime = Infinity;
 
     this._allRecordsCount = 0;
     this._createOverviewControls();
     if (this._frameMode) {
         this._presentationModel.setGlueRecords(false);
         this._frameController = new WebInspector.TimelineFrameController(this._model, this._frameOverviewControl, this._presentationModel);
     } else {
         this._presentationModel.setGlueRecords(glueRecordsSetting.get());
@@ skipping 338 matching lines @@
         function isAdoptedRecord(record)
         {
             return record.parent !== presentationModel.rootRecord;
         }
         // Tell caller update is necessary either if we added a visible record or if we re-parented a record.
         return hasVisibleRecords || records.some(isAdoptedRecord);
     },
 
     _sidebarResized: function()
     {
-        var width = this._sidebarView.sidebarWidth();
+        var width = this._recordsView.sidebarWidth();
         this._panel.setSidebarWidth(width);
         if (this._currentMode === WebInspector.TimelinePanel.Mode.Memory)
             this._memoryStatistics.setSidebarWidth(width);
         this._timelineGrid.gridHeaderElement.style.left = width + "px";
     },
 
     /**
      * @param {number} width
      */
     setSidebarWidth: function(width)
     {
         if (this._currentMode === WebInspector.TimelinePanel.Mode.Memory)
-            this._sidebarView.setSidebarWidth(width);
+            this._recordsView.setSidebarWidth(width);
     },
 
     _onViewportResize: function()
     {
-        this._resize(this._sidebarView.sidebarWidth());
+        this._resize(this._recordsView.sidebarWidth());
     },
 
     /**
      * @param {number} sidebarWidth
      */
     _resize: function(sidebarWidth)
     {
         this._closeRecordDetails();
         this._graphRowsElementWidth = this._graphRowsElement.offsetWidth;
         this._containerElementHeight = this._containerElement.clientHeight;
@@ skipping 328 matching lines @@
             var windowStartTime = startIndex ? recordsInWindow[startIndex].startTime : this._model.minimumRecordTime();
             this._setWindowTimes(windowStartTime, recordsInWindow[Math.max(0, lastVisibleLine - 1)].endTime);
             recordsInWindow = this._presentationModel.filteredRecords();
             endIndex = Math.min(recordsInWindow.length, lastVisibleLine);
         } else {
             this._updateWindowBoundaries();
         }
 
         // Resize gaps first.
         this._topGapElement.style.height = (startIndex * rowHeight) + "px";
-        this._sidebarView.sidebarElement().firstChild.style.flexBasis = (startIndex * rowHeight + headerHeight) + "px";
+        this._recordsView.sidebarElement().firstChild.style.flexBasis = (startIndex * rowHeight + headerHeight) + "px";
         this._bottomGapElement.style.height = (recordsInWindow.length - endIndex) * rowHeight + "px";
         var rowsHeight = headerHeight + recordsInWindow.length * rowHeight;
         var totalHeight = Math.max(this._containerElementHeight, rowsHeight);
 
-        this._sidebarView.firstElement().style.height = totalHeight + "px";
-        this._sidebarView.secondElement().style.height = totalHeight + "px";
-        this._sidebarView.resizerElement().style.height = totalHeight + "px";
+        this._recordsView.firstElement().style.height = totalHeight + "px";
+        this._recordsView.secondElement().style.height = totalHeight + "px";
+        this._recordsView.resizerElement().style.height = totalHeight + "px";
 
         // Update visible rows.
         var listRowElement = this._sidebarListElement.firstChild;
         var width = this._graphRowsElementWidth;
         this._itemsGraphsElement.removeChild(this._graphRowsElement);
         var graphRowElement = this._graphRowsElement.firstChild;
         var scheduleRefreshCallback = this._invalidateAndScheduleRefresh.bind(this, true, true);
         var selectRecordCallback = this._selectRecord.bind(this);
         this._itemsGraphsElement.removeChild(this._expandElements);
         this._expandElements.removeChildren();
@@ skipping 974 matching lines @@
      * @param {boolean} vertical
      */
     setVertical: function(vertical)
     {
         this._contentElement.enableStyleClass("hbox", !vertical);
         this._contentElement.enableStyleClass("vbox", vertical);
     },
 
     __proto__: WebInspector.View.prototype
 }