Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 136363003: TimelinePanel: rename _sidebarView to _recordsView (Closed)

Created:
6 years, 11 months ago by loislo
Modified:
6 years, 11 months ago
Reviewers:
caseq, alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

TimelinePanel: rename _sidebarView to _recordsView TimelineView has member _sidebarView which is actually is a top level container for records. DriveBy: rearrange groups of calls that relate to recordsView into single chunk of code. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164963

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M Source/devtools/front_end/TimelineView.js View 6 chunks +42 lines, -41 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
loislo
6 years, 11 months ago (2014-01-13 12:47:29 UTC) #1
pfeldman
https://codereview.chromium.org/136363003/diff/1/Source/devtools/front_end/TimelineView.js File Source/devtools/front_end/TimelineView.js (right): https://codereview.chromium.org/136363003/diff/1/Source/devtools/front_end/TimelineView.js#newcode140 Source/devtools/front_end/TimelineView.js:140: // Create memory splitter as a left child of ...
6 years, 11 months ago (2014-01-13 12:49:02 UTC) #2
pfeldman
lgtm
6 years, 11 months ago (2014-01-13 13:13:00 UTC) #3
loislo
6 years, 11 months ago (2014-01-13 13:21:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r164963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698