Issue 136363003: TimelinePanel: rename _sidebarView to _recordsView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136363003: TimelinePanel: rename _sidebarView to _recordsView (Closed)

Created:
6 years, 11 months ago by loislo

Modified:
6 years, 11 months ago

Reviewers:
caseq, alph, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

TimelinePanel: rename _sidebarView to _recordsView TimelineView has member _sidebarView which is actually is a top level container for records. DriveBy: rearrange groups of calls that relate to recordsView into single chunk of code. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164963

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -41 lines)			Patch
	M	Source/devtools/front_end/TimelineView.js	View		6 chunks	+42 lines, -41 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/136363003/diff/1/Source/devtools/front_end/TimelineView.js File Source/devtools/front_end/TimelineView.js (right): https://codereview.chromium.org/136363003/diff/1/Source/devtools/front_end/TimelineView.js#newcode140 Source/devtools/front_end/TimelineView.js:140: // Create memory splitter as a left child of ...

6 years, 11 months ago (2014-01-13 12:49:02 UTC) #2

loislo

6 years, 11 months ago (2014-01-13 13:21:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r164963 (presubmit successful).

Expand Messages | Collapse Messages