Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

Issue 1363613004: Implement anonymous, opt-in, collection of OS X binary integrity incidents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix windows build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h
diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h
index 6ac4532aaae29578ce7cdc784a9de7e37fb7c0b9..4c99bf5217d36312db845ea95f1a0f076a24e45f 100644
--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h
+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h
@@ -5,12 +5,14 @@
#ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_BINARY_INTEGRITY_ANALYZER_H_
#define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_BINARY_INTEGRITY_ANALYZER_H_
-#include <vector>
+#include <string>
+#include <utility>
#include "base/memory/scoped_ptr.h"
namespace base {
class FilePath;
+class TimeDelta;
} // namespace base
namespace safe_browsing {
@@ -26,8 +28,14 @@ void RegisterBinaryIntegrityAnalysis();
// service will decide when to start the analysis.
void VerifyBinaryIntegrity(scoped_ptr<IncidentReceiver> incident_receiver);
-// Returns a vector containing the paths to all the binaries to verify.
-std::vector<base::FilePath> GetCriticalBinariesPath();
+// Record how long the signature verification took.
+void RecordSignatureVerificationTime(size_t file_index,
+ const base::TimeDelta& verification_time);
+
+// Clear past incident reports for a file or bundle. This is used if the code
+// object is now integral, as it will allow future incidents to be reported.
+void ClearIntegrityReports(IncidentReceiver* incident_receiver,
grt (UTC plus 2) 2015/10/28 17:49:51 ClearBinaryIntegrityForFile?
Greg K 2015/10/29 23:51:31 Done.
+ const std::string& basename);
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698