Implement anonymous, opt-in, collection of OS X binary integrity incidents.

chrome/common/safe_browsing/csd.proto

Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index e55d1ca4ad0f304c20ac4e5f9fb306bae23063f1..a5e351f962fca996dc67aac8f50c9dd7144bb93f 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -208,6 +208,13 @@ message ClientDownloadRequest {
     repeated Element element = 1;
   }
 
+  message ExtendedAttr {

[Robert Sesek, 2015/10/08 19:20:06]

Document the message type too, specifically calling it out as an OS X-only
message.

[Greg K, 2015/10/09 17:12:01]

Done.

+    // This is the name of the extended attribute.
+    required string key = 1;
+    // This is the value of the extended attribute.
+    optional bytes value = 2;
+  }
+
   message SignatureInfo {
     // All certificate chains for each of the binary's signers.  Multiple chains
     // may be present if the binary or any certificate has multiple signers.
@@ -225,6 +232,11 @@ message ClientDownloadRequest {
     // On Mac, this is the code signature blob referenced by the
     // LC_CODE_SIGNATURE load command.
     repeated bytes signed_data = 3;
+
+    // On OS X, code signing data can be contained in the extended attributes of
+    // a file. As GateKeeper respects this signature, we look for it and collect
+    // it.
+    repeated ExtendedAttr xattr = 4;
   }
 
   // This field will only be set if the binary is signed.
@@ -421,10 +433,14 @@ message ClientIncidentReport {
       repeated string split_key = 3;
       optional ValueState value_state = 4;
     }
+
     message BinaryIntegrityIncident {
       optional string file_basename = 1;
       optional ClientDownloadRequest.SignatureInfo signature = 2;
+      optional ClientDownloadRequest.ImageHeaders image_headers = 3;
+      optional int32 sec_error = 4;
     }
+
     message BlacklistLoadIncident {
       optional string path = 1;
       optional ClientDownloadRequest.Digests digest = 2;