Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: tests/standalone/io/dart_std_io_pipe_test.dart

Issue 13636003: Fix a number of issues with determining the type of stdio (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/dart_std_io_pipe_script.dart ('k') | tests/standalone/io/dart_std_io_pipe_test.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/dart_std_io_pipe_test.dart
diff --git a/tests/standalone/io/dart_std_io_pipe_test.dart b/tests/standalone/io/dart_std_io_pipe_test.dart
index daf5c098ee423d8a0795103cfe3d3e0d95a63cec..4310d7813639a716f47c2cb8531e3b9585f34cf4 100644
--- a/tests/standalone/io/dart_std_io_pipe_test.dart
+++ b/tests/standalone/io/dart_std_io_pipe_test.dart
@@ -40,7 +40,12 @@ void test(String shellScript, String dartScript, String type, bool devNull) {
String redirectOutFile = "${dir.path}/redirect";
String executable = new Options().executable;
List args =
- [executable, dartScript, type, pipeOutFile, redirectOutFile];
+ [executable,
+ dartScript,
+ type,
+ pipeOutFile,
+ redirectOutFile,
+ devNull ? "terminal" : "file"];
var future = Process.start(shellScript, args);
future.then((process) {
process.exitCode.then((exitCode) {
@@ -105,9 +110,10 @@ main() {
shellScript = new File("../tests/standalone/io/dart_std_io_pipe_test.sh");
}
// Get the Dart script file which echoes stdin to stdout or stderr or both.
- var scriptFile = new File("tests/standalone/io/process_std_io_script.dart");
+ var scriptFile = new File("tests/standalone/io/dart_std_io_pipe_script.dart");
if (!scriptFile.existsSync()) {
- scriptFile = new File("../tests/standalone/io/process_std_io_script.dart");
+ scriptFile =
+ new File("../tests/standalone/io/dart_std_io_pipe_script.dart");
}
// Run the shell script.
« no previous file with comments | « tests/standalone/io/dart_std_io_pipe_script.dart ('k') | tests/standalone/io/dart_std_io_pipe_test.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698