Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4060)

Unified Diff: chrome/browser/resources/media_router/media_router_ui_interface.js

Issue 1363593003: [Media Router] Set timeout for route creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per imcheng@'s comments and offline conversation. Rebase (forgot to upload separately, sorry!). Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router_ui_interface.js
diff --git a/chrome/browser/resources/media_router/media_router_ui_interface.js b/chrome/browser/resources/media_router/media_router_ui_interface.js
index 3a4faf80995fecc43b04e5632ebe3c4d0e39325d..6fc2d2f2483a4119dc0a23d150d5a14f7fc6b8d0 100644
--- a/chrome/browser/resources/media_router/media_router_ui_interface.js
+++ b/chrome/browser/resources/media_router/media_router_ui_interface.js
@@ -10,6 +10,10 @@ cr.define('media_router.ui', function() {
// The media-router-container element.
var container = null;
+ function onNotifyRouteCreationTimeout() {
+ container.isLaunching = false;
imcheng 2015/10/02 21:57:30 do we also need to set the launch state for the si
apacible 2015/10/02 23:45:16 See thread in media_router_container.js.
+ }
+
/**
* Handles response of previous create route attempt.
*
@@ -44,7 +48,7 @@ cr.define('media_router.ui', function() {
* Populates the WebUI with data obtained from Media Router.
*
* @param {headerText: string,
- * headerTextTooltip: string,
+ * headerTextTooltip: string,-
imcheng 2015/10/02 21:57:30 extra - at the end
apacible 2015/10/02 23:45:16 Done.
* deviceMissingUrl: string,
* sinks: !Array<!media_router.Sink>,
* routes: !Array<!media_router.Route>,
@@ -95,6 +99,7 @@ cr.define('media_router.ui', function() {
}
return {
+ onNotifyRouteCreationTimeout: onNotifyRouteCreationTimeout,
onCreateRouteResponseReceived: onCreateRouteResponseReceived,
setCastModeList: setCastModeList,
setContainer: setContainer,

Powered by Google App Engine
This is Rietveld 408576698