chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html - Issue 1363593003: [Media Router] Set timeout for route creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 1363593003: [Media Router] Set timeout for route creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments and offline conversation. Rebase (forgot to upload separately, sorry!). Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/media_router_strings.grdp ('k') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('j') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

index d04a3121d5a00037047ebca11e427992a0876044..56b3db260569c5f8b8c242b29d80a7f95425d1ee 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

@@ -25,7 +25,7 @@

id="cast-mode-header-text">[[selectCastModeHeaderText_]]</span>

</div>

<paper-icon-button icon="[[computeArrowDropIcon_(currentView_)]]"

- disabled$="[[isLaunching_(sinkList)]]" id="arrow-drop-icon"

+ disabled$="[[isLaunching]]" id="arrow-drop-icon"

on-click="toggleCastModeHidden_">

</paper-icon-button>

<paper-icon-button icon="close" id="close-button"

@@ -86,10 +86,11 @@

<div>

<iron-icon icon="[[computeSinkIcon_(item)]]"

- hidden$="[[item.isLaunching]]"

+ hidden$="[[computeSinkIsLaunching_(isLaunching, item.isLaunching)]]"

class$="[[computeSinkIconClass_(item.id, sinkToRouteMap_)]]">

</iron-icon>

- <template is="dom-if" if="[[item.isLaunching]]">

+ <template is="dom-if"

+ if="[[computeSinkIsLaunching_(isLaunching, item.isLaunching)]]">

<paper-spinner class="sink-icon" active>

</paper-spinner>

</template>