Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1363553002: [heap] Process live weak cells directly in the marking visitor. (Closed)

Created:
5 years, 3 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Process live weak cells directly in the marking visitor. This reduces the pause time of weak cells processing during a full GC. BUG= Committed: https://crrev.com/0bfb773de2e165983deb020c35c7dc97ca164975 Cr-Commit-Position: refs/heads/master@{#30864}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/heap/objects-visiting-inl.h View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 3 months ago (2015-09-22 11:19:44 UTC) #2
ulan
lgtm if it is a bottleneck in a benchmark. https://codereview.chromium.org/1363553002/diff/1/src/heap/objects-visiting-inl.h File src/heap/objects-visiting-inl.h (right): https://codereview.chromium.org/1363553002/diff/1/src/heap/objects-visiting-inl.h#newcode358 src/heap/objects-visiting-inl.h:358: ...
5 years, 3 months ago (2015-09-22 11:30:46 UTC) #3
Hannes Payer (out of office)
It is a bottleneck on many websites. https://codereview.chromium.org/1363553002/diff/1/src/heap/objects-visiting-inl.h File src/heap/objects-visiting-inl.h (right): https://codereview.chromium.org/1363553002/diff/1/src/heap/objects-visiting-inl.h#newcode358 src/heap/objects-visiting-inl.h:358: if (MarkCompactCollector::IsMarked(value)) ...
5 years, 2 months ago (2015-09-22 13:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363553002/20001
5 years, 2 months ago (2015-09-22 13:23:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-22 13:48:17 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-22 13:48:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bfb773de2e165983deb020c35c7dc97ca164975
Cr-Commit-Position: refs/heads/master@{#30864}

Powered by Google App Engine
This is Rietveld 408576698