Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1363523003: Enable SiteEngagementEvictionPolicy behind --enable-site-eviction-policy flag. (Closed)

Created:
5 years, 3 months ago by calamity
Modified:
5 years, 1 month ago
Reviewers:
dominickn, raymes, jam
CC:
chromium-reviews, darin-cc_chromium.org, wjmaclean, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lru_policy_gooood
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable SiteEngagementEvictionPolicy behind --enable-site-eviction-policy flag. This CL enables a new SiteEngagementEvictionPolicy in the QuotaManager which determines the eviction priority of temporary storage origins based on a heuristic calculation of a user's engagement with that site. This feature is behind the --enable-site-eviction-policy flag. This flag will also implicitly enable the site engagement service. BUG=542075 Committed: https://crrev.com/c96116b9c01f80d7c793cc0f6bc032c5379b93e8 Cr-Commit-Position: refs/heads/master@{#357531}

Patch Set 1 : #

Total comments: 9

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Patch Set 4 : selfnit #

Total comments: 2

Patch Set 5 : rebase #

Patch Set 6 : address comments #

Patch Set 7 : fix flag dependencies #

Total comments: 2

Patch Set 8 : fix nit #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -10 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_eviction_policy.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_eviction_policy.cc View 1 2 3 4 5 6 7 8 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/engagement/site_engagement_service.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service.cc View 1 2 3 4 5 6 7 8 5 chunks +15 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (9 generated)
calamity
5 years, 3 months ago (2015-09-23 02:16:46 UTC) #3
raymes
5 years, 3 months ago (2015-09-23 02:34:35 UTC) #5
dominickn
https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.h File chrome/browser/chrome_content_browser_client.h (right): https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.h#newcode174 chrome/browser/chrome_content_browser_client.h:174: void AddQuotaEvictionPolicies(content::BrowserContext* context, Nit: can there be multiple policies ...
5 years, 3 months ago (2015-09-24 00:53:42 UTC) #6
raymes
https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.cc#newcode1888 chrome/browser/chrome_content_browser_client.cc:1888: void ChromeContentBrowserClient::AddQuotaEvictionPolicies( I guess the alternate API would look ...
5 years, 3 months ago (2015-09-24 01:55:31 UTC) #7
calamity
Big ol' rebase. PTAL. https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/1363523003/diff/20001/chrome/browser/chrome_content_browser_client.cc#newcode1888 chrome/browser/chrome_content_browser_client.cc:1888: void ChromeContentBrowserClient::AddQuotaEvictionPolicies( On 2015/09/24 01:55:30, ...
5 years, 1 month ago (2015-10-26 03:01:57 UTC) #8
raymes
lgtm except it's probably good to find an appropriate storage reviewer for content/browser/storage_partition_impl_map.cc https://codereview.chromium.org/1363523003/diff/80001/chrome/browser/engagement/site_engagement_service.cc File ...
5 years, 1 month ago (2015-10-27 01:57:05 UTC) #10
dominickn
Do you want to have this enabled under a Finch experiment? If so, you might ...
5 years, 1 month ago (2015-10-27 02:22:00 UTC) #11
calamity
On 2015/10/27 02:22:00, dominickn wrote: > Do you want to have this enabled under a ...
5 years, 1 month ago (2015-10-28 04:36:57 UTC) #12
calamity
+jam for content/ OWNERS. https://codereview.chromium.org/1363523003/diff/80001/chrome/browser/engagement/site_engagement_service.cc File chrome/browser/engagement/site_engagement_service.cc (right): https://codereview.chromium.org/1363523003/diff/80001/chrome/browser/engagement/site_engagement_service.cc#newcode254 chrome/browser/engagement/site_engagement_service.cc:254: const std::string group_name = On ...
5 years, 1 month ago (2015-10-28 04:38:54 UTC) #14
dominickn
On 2015/10/28 04:36:57, calamity wrote: > On 2015/10/27 02:22:00, dominickn wrote: > > Do you ...
5 years, 1 month ago (2015-10-28 05:33:45 UTC) #15
calamity
On 2015/10/28 05:33:45, dominickn wrote: > On 2015/10/28 04:36:57, calamity wrote: > > On 2015/10/27 ...
5 years, 1 month ago (2015-10-28 06:50:09 UTC) #16
dominickn
I had to think for a moment whether it was best to have this under ...
5 years, 1 month ago (2015-10-28 23:07:35 UTC) #18
jam
i have no idea what this feature is, and the tracking bug has no useful ...
5 years, 1 month ago (2015-10-29 19:13:33 UTC) #19
calamity
On 2015/10/29 19:13:33, jam wrote: > i have no idea what this feature is, and ...
5 years, 1 month ago (2015-10-30 00:58:54 UTC) #21
jam
On 2015/10/30 00:58:54, calamity wrote: > On 2015/10/29 19:13:33, jam wrote: > > i have ...
5 years, 1 month ago (2015-10-30 16:17:00 UTC) #22
calamity
On 2015/10/30 16:17:00, jam wrote: > On 2015/10/30 00:58:54, calamity wrote: > > On 2015/10/29 ...
5 years, 1 month ago (2015-11-02 02:55:15 UTC) #23
jam
lgtm https://codereview.chromium.org/1363523003/diff/160001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): https://codereview.chromium.org/1363523003/diff/160001/content/public/browser/content_browser_client.h#newcode452 content/public/browser/content_browser_client.h:452: GetTemporaryStorageEvictionPolicy(content::BrowserContext* context); nit: no content::
5 years, 1 month ago (2015-11-02 18:36:37 UTC) #24
calamity
https://codereview.chromium.org/1363523003/diff/160001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): https://codereview.chromium.org/1363523003/diff/160001/content/public/browser/content_browser_client.h#newcode452 content/public/browser/content_browser_client.h:452: GetTemporaryStorageEvictionPolicy(content::BrowserContext* context); On 2015/11/02 18:36:37, jam wrote: > nit: ...
5 years, 1 month ago (2015-11-03 04:26:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363523003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363523003/200001
5 years, 1 month ago (2015-11-03 04:27:04 UTC) #28
commit-bot: I haz the power
Committed patchset #9 (id:200001)
5 years, 1 month ago (2015-11-03 04:30:59 UTC) #29
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 04:32:02 UTC) #30
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/c96116b9c01f80d7c793cc0f6bc032c5379b93e8
Cr-Commit-Position: refs/heads/master@{#357531}

Powered by Google App Engine
This is Rietveld 408576698