Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1363483007: Reland of Add a NavigationThrottle to the public content/ interface (Closed)

Created:
5 years, 3 months ago by clamy
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, android-webview-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add a NavigationThrottle to the public content/ interface This CL relands patch https://codereview.chromium.org/1269813002/ that was reverted because it broke some extension tests on ChromeOS. Original commit message: This CL adds a NavigationThrottle class to the public content/ interface. A NavigationThrottle is used to control the flow of navigations. It lives entirely on the UI thread. Eventually, all components that want the functionality of a ResourceThrottle for navigations should transition to a NavigationThrottle: the new architecture for navigations (browser-side navigation) will not support ResourceThrottles for main resources load. See https://docs.google.com/document/d/1ICLLQoC9EsZ-bWH4ZKRhPCIoZKn6pOj02SlGl6SKH6Y/edit?pli=1#heading=h.fmxjmgvbgg7x for the design doc. This Cl also transition the InterceptNavigationResourceThrottle to the NavigationThrottle model. BUG=504347 TBR=mnaganov@chromium.org, sky@chromium.org, asargent@chromium.org, creis@chromium.org, nasko@chromium.org Committed: https://crrev.com/40c9e144d4864ee6fa3854e59b322df6107cbe7e Cr-Commit-Position: refs/heads/master@{#351284}

Patch Set 1 #

Patch Set 2 : Rebase on 1350673003 #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1020 lines, -814 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/apps/app_url_redirector.h View 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/apps/app_url_redirector.cc View 3 chunks +31 lines, -38 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 4 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/navigation_interception/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.h View 3 chunks +8 lines, -8 lines 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc View 1 chunk +0 lines, -481 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle.h View 1 chunk +51 lines, -0 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle_unittest.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 6 chunks +55 lines, -8 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 5 chunks +129 lines, -8 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 3 chunks +31 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A content/browser/loader/navigation_resource_throttle.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/browser/loader/navigation_resource_throttle.cc View 1 chunk +154 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/navigation_handle.h View 1 2 chunks +82 lines, -5 lines 0 comments Download
A content/public/browser/navigation_handle.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A content/public/browser/navigation_throttle.h View 1 chunk +43 lines, -0 lines 0 comments Download
A content/public/browser/navigation_throttle.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 1 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
clamy
@asargent, creis, mnaganov, nasko, sky: this is a reland of https://codereview.chromium.org/1269813002/. The original patch exposed ...
5 years, 2 months ago (2015-09-29 09:55:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363483007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363483007/100001
5 years, 2 months ago (2015-09-29 09:56:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126876)
5 years, 2 months ago (2015-09-29 10:38:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363483007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363483007/100001
5 years, 2 months ago (2015-09-29 10:49:13 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 2 months ago (2015-09-29 11:18:59 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 11:19:52 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40c9e144d4864ee6fa3854e59b322df6107cbe7e
Cr-Commit-Position: refs/heads/master@{#351284}

Powered by Google App Engine
This is Rietveld 408576698