Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 1363463002: [Extensions Toolbar] Add a finch config for the redesign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finnur's Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
index 657dc4041cb2867619060c728c1ee31ba3a58219..4789f2928f0d8da74dc38595160453ee421faa21 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
@@ -234,10 +234,12 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {
NSMaxY(bounds) - extension_installed_bubble::kAppsBubbleArrowOffset);
arrowPoint = [button convertPoint:anchor toView:nil];
} else if (type_ == extension_installed_bubble::kBrowserAction ||
- extensions::FeatureSwitch::extension_action_redesign()->
- IsEnabled()) {
+ (extensions::FeatureSwitch::extension_action_redesign()->
+ IsEnabled() &&
+ type_ != extension_installed_bubble::kBundle)) {
// If the toolbar redesign is enabled, all bubbles for extensions point to
- // their toolbar action.
+ // their toolbar action. The exception is for bundles, for which there is no
+ // single associated extension.
BrowserActionsController* controller =
[[window->cocoa_controller() toolbarController]
browserActionsController];
« no previous file with comments | « chrome/browser/extensions/location_bar_controller.cc ('k') | chrome/browser/ui/location_bar/location_bar_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698