Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h

Issue 1363463002: [Extensions Toolbar] Add a finch config for the redesign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h
diff --git a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h
index 3dcf83cf7a4c029d59a9d7735c2b91f1d8d45fec..15140da9d0098835055ffe62c235ea4217b76341 100644
--- a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h
+++ b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h
@@ -48,7 +48,7 @@ class BrowserActionsBarBrowserTest : public ExtensionBrowserTest {
return extension_c_.get();
}
- private:
+ protected:
scoped_ptr<BrowserActionTestUtil> browser_actions_bar_;
// The associated toolbar model, weak.
@@ -59,6 +59,10 @@ class BrowserActionsBarBrowserTest : public ExtensionBrowserTest {
scoped_refptr<const extensions::Extension> extension_b_;
scoped_refptr<const extensions::Extension> extension_c_;
Finnur 2015/09/22 14:18:32 Do all these need to be protected as well?
Devlin 2015/09/23 00:28:35 Probably not. :) Done.
+ // Enable or disable the feature redesign switch.
+ scoped_ptr<extensions::FeatureSwitch::ScopedOverride> override_redesign_;
+
+ private:
DISALLOW_COPY_AND_ASSIGN(BrowserActionsBarBrowserTest);
};
@@ -72,9 +76,6 @@ class BrowserActionsBarRedesignBrowserTest
void SetUpCommandLine(base::CommandLine* command_line) override;
private:
- // Enable the feature redesign switch.
- scoped_ptr<extensions::FeatureSwitch::ScopedOverride> enable_redesign_;
-
DISALLOW_COPY_AND_ASSIGN(BrowserActionsBarRedesignBrowserTest);
};

Powered by Google App Engine
This is Rietveld 408576698