Issue 136343004: Mojo: Add a "GetType()" to Dispatchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136343004: Mojo: Add a "GetType()" to Dispatchers. (Closed)

Created:
6 years, 10 months ago by viettrungluu

Modified:
6 years, 10 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add a "GetType()" to Dispatchers. In sending handles across processes, the ProxyMessagePipeEndpoint will need to go from a generic Dispatcher to specific dispatcher types. (The alternative is to have layers of complex abstraction....) Also, at some point, I'll probably add the ability to query the type of a handle (along with other information). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247754

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -0 lines)			Patch
M	mojo/system/core_test_base.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/system/data_pipe_consumer_dispatcher.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/data_pipe_consumer_dispatcher.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/system/data_pipe_producer_dispatcher.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/data_pipe_producer_dispatcher.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/system/dispatcher.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	mojo/system/dispatcher_unittest.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/system/simple_dispatcher_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 10 months ago (2014-01-29 22:20:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r247754 (presubmit successful).

Expand Messages | Collapse Messages