Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136343002: Remove Chrome for TV code. (Closed)

Created:
6 years, 11 months ago by ycheo (away)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added the crbug. #

Total comments: 2

Patch Set 3 : Addressed wonsik's comment. #

Total comments: 4

Patch Set 4 : Addressed scherkus's comments. #

Total comments: 2

Patch Set 5 : Fixed a nit. #

Patch Set 6 : Rebased & added some missing files. #

Patch Set 7 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1535 lines) Patch
M base/android/base_jni_registrar.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D base/android/context_types.h View 1 chunk +0 lines, -22 lines 0 comments Download
D base/android/context_types.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D base/android/java/src/org/chromium/base/ContextTypes.java View 1 chunk +0 lines, -96 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +1 line, -24 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/ContextTypesTest.java View 1 chunk +0 lines, -43 lines 0 comments Download
M base/base.gyp View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download
M base/base.gypi View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 7 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/android/chrome_startup_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 1 2 3 4 5 2 chunks +0 lines, -27 lines 0 comments Download
D chrome/browser/resources/plugin_metadata/plugins_tv.json View 1 2 3 4 5 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/media/media_player_messages_enums_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DeviceUtils.java View 1 2 3 4 chunks +0 lines, -26 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/PepperPluginManager.java View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 1 2 3 5 chunks +0 lines, -18 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 3 4 19 chunks +16 lines, -82 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 4 chunks +0 lines, -24 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 11 chunks +1 line, -90 lines 0 comments Download
M content/renderer/media/crypto/key_systems.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 1 2 3 4 5 3 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 3 4 5 3 chunks +0 lines, -13 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_bridge_tv.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_bridge_tv.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_factory_tv.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_factory_tv.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D content/renderer/media/rtc_video_decoder_factory_tv_unittest.cc View 1 chunk +0 lines, -348 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 4 chunks +2 lines, -28 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 2 chunks +0 lines, -7 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/user_agent/user_agent_util.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
ycheo (away)
6 years, 11 months ago (2014-01-13 08:44:33 UTC) #1
Jinsuk Kim
On 2014/01/13 08:44:33, Yuncheol Heo wrote: lgtm
6 years, 11 months ago (2014-01-13 09:45:06 UTC) #2
kjyoun.chromium
lgtm
6 years, 11 months ago (2014-01-14 02:25:23 UTC) #3
dwkang1
lgtm
6 years, 11 months ago (2014-01-14 02:44:37 UTC) #4
wonsik
lgtm % nit https://codereview.chromium.org/136343002/diff/70001/content/renderer/media/android/webmediaplayer_android.h File content/renderer/media/android/webmediaplayer_android.h (left): https://codereview.chromium.org/136343002/diff/70001/content/renderer/media/android/webmediaplayer_android.h#oldcode234 content/renderer/media/android/webmediaplayer_android.h:234: // Can be called on any ...
6 years, 11 months ago (2014-01-14 05:22:22 UTC) #5
ycheo (away)
https://codereview.chromium.org/136343002/diff/70001/content/renderer/media/android/webmediaplayer_android.h File content/renderer/media/android/webmediaplayer_android.h (left): https://codereview.chromium.org/136343002/diff/70001/content/renderer/media/android/webmediaplayer_android.h#oldcode234 content/renderer/media/android/webmediaplayer_android.h:234: // Can be called on any thread. On 2014/01/14 ...
6 years, 11 months ago (2014-01-14 05:28:43 UTC) #6
ycheo (away)
Adding OWNERS. Apologies for the long list: darin: base/base.gyp* webkit/common/user_agent/ jochen: chrome/browser/ chrome/chrome_renderer.gypi content/browser/render_host/ content/child/ ...
6 years, 11 months ago (2014-01-14 09:07:27 UTC) #7
ycheo (away)
6 years, 11 months ago (2014-01-14 09:10:24 UTC) #8
jochen (gone - plz use gerrit)
rslgtm
6 years, 11 months ago (2014-01-14 09:32:56 UTC) #9
qinmin
lgtm
6 years, 11 months ago (2014-01-14 18:56:15 UTC) #10
Yaron
lgtm Commented on the internal CL as well.. I think there's more cleanup you can ...
6 years, 11 months ago (2014-01-14 19:08:07 UTC) #11
scherkus (not reviewing)
https://codereview.chromium.org/136343002/diff/100001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/136343002/diff/100001/content/renderer/media/android/media_source_delegate.cc#newcode157 content/renderer/media/android/media_source_delegate.cc:157: demuxer_ = chunk_demuxer_.get(); I think we can remove the ...
6 years, 11 months ago (2014-01-14 19:08:36 UTC) #12
ycheo (away)
https://codereview.chromium.org/136343002/diff/100001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/136343002/diff/100001/content/renderer/media/android/media_source_delegate.cc#newcode157 content/renderer/media/android/media_source_delegate.cc:157: demuxer_ = chunk_demuxer_.get(); On 2014/01/14 19:08:37, scherkus wrote: > ...
6 years, 11 months ago (2014-01-14 23:45:37 UTC) #13
scherkus (not reviewing)
lgtm w/ one nit thanks! https://codereview.chromium.org/136343002/diff/180001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/136343002/diff/180001/content/renderer/media/android/media_source_delegate.cc#newcode130 content/renderer/media/android/media_source_delegate.cc:130: base::Unretained(this))); fix indent
6 years, 11 months ago (2014-01-14 23:58:36 UTC) #14
ycheo (away)
https://codereview.chromium.org/136343002/diff/180001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/136343002/diff/180001/content/renderer/media/android/media_source_delegate.cc#newcode130 content/renderer/media/android/media_source_delegate.cc:130: base::Unretained(this))); On 2014/01/14 23:58:37, scherkus wrote: > fix indent ...
6 years, 11 months ago (2014-01-15 00:11:10 UTC) #15
ycheo (away)
@plamer, @darin, PTAL at this.
6 years, 11 months ago (2014-01-15 23:30:06 UTC) #16
ycheo (away)
Palmer looks busy. @tsepez, Could you take a look at the following files? content/common/media/media_player_messages_*android.h Thanks, ...
6 years, 11 months ago (2014-01-16 10:32:55 UTC) #17
ycheo (away)
Darlin looks busy. @thakis, PTAL at the following files: base/base.gyp* @tony, PTAL at the following ...
6 years, 11 months ago (2014-01-16 10:56:43 UTC) #18
tony
webkit/ LGTM. BTW, I updated the change description. It's not common to use the plural ...
6 years, 11 months ago (2014-01-16 17:38:20 UTC) #19
Nico
base lgtm You missed this file: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/browser_resources.grd&q=google_tv%20file:grd&sq=package:chromium&l=198
6 years, 11 months ago (2014-01-16 19:30:24 UTC) #20
Tom Sepez
messages LGTM
6 years, 11 months ago (2014-01-16 19:59:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/136343002/420001
6 years, 11 months ago (2014-01-17 04:41:10 UTC) #22
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 06:52:29 UTC) #23
Message was sent while issue was closed. 
Change committed as 245449

Powered by Google App Engine
This is Rietveld 408576698