Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1363403003: Update post-mortem metadata generation (Closed)

Created:
5 years, 3 months ago by julien.gilli
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update post-mortem metadata generation mdb_v8, a post-mortem debugger for Node.js, now uses JSArrayBuffer's backing_store property and JSArrayBufferView's byte_offset property to get access to the content of Buffer instances in node (which are Uint8Array instances). This change adds post-mortem metadata for these two properties. This change also fixes a typo in inobject_properties_of_constructor_function_index_offset that was added to gen-postmortem-metadata in a previous change. It should be named inobject_properties_or_constructor_function_index instead. R=bmeurer@chromium.org Committed: https://crrev.com/56a0a797f210e04746f2888116365d29a4bb6afc Cr-Commit-Position: refs/heads/master@{#30926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
julien.gilli
5 years, 3 months ago (2015-09-25 00:05:39 UTC) #1
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-09-25 04:16:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363403003/1
5 years, 2 months ago (2015-09-25 04:35:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 04:59:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56a0a797f210e04746f2888116365d29a4bb6afc Cr-Commit-Position: refs/heads/master@{#30926}
5 years, 2 months ago (2015-09-25 04:59:55 UTC) #7
julien.gilli
5 years, 2 months ago (2015-09-25 05:14:41 UTC) #8
Message was sent while issue was closed.
On 2015/09/25 04:16:24, Benedikt Meurer wrote:
> lgtm

Once again, thank you very much for the prompt review!

Powered by Google App Engine
This is Rietveld 408576698