Descriptionclang/win: Fix component build after https://codereview.chromium.org/1365003002
CORE_EXPORT GC_PLUGIN_IGNORE("535448") expands to
`__declspec(dllexport) __attribute__((annotate("blink_gc_plugin_ignore")))` with
clang/win, but clang only understands the other order. (On non-Windows,
CORE_EXPORT expands to an __attribute__ too, and those can be listed in any
order.)
This causes a pretty bad diagnostic, I filed a clang bug to improve it (http://llvm.org/PR24925):
In file included from ..\..\third_party\WebKit\Source\core\animation\DeferredLegacyStyleInterpolation.cpp:10:
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration of anonymous class must be a definition
class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue {
^
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration does not declare anything [-Werror,-Wmissing-declarations]
class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue {
^
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(78,47) : error: base class has incomplete type
class CSSBasicShapeCircleValue final : public CSSBasicShapeValue {
~~~~~~~^~~~~~~~~~~~~~~~~~
BUG=82385
R=sigbjornf@opera.com
Committed: https://chromium.googlesource.com/chromium/src/+/3442a5559a27b3ba64a277d5171b89f005a2f5db
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|