Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1363363002: clang/win: Fix component build after https://codereview.chromium.org/1365003002 (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
sof
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix component build after https://codereview.chromium.org/1365003002 CORE_EXPORT GC_PLUGIN_IGNORE("535448") expands to `__declspec(dllexport) __attribute__((annotate("blink_gc_plugin_ignore")))` with clang/win, but clang only understands the other order. (On non-Windows, CORE_EXPORT expands to an __attribute__ too, and those can be listed in any order.) This causes a pretty bad diagnostic, I filed a clang bug to improve it (http://llvm.org/PR24925): In file included from ..\..\third_party\WebKit\Source\core\animation\DeferredLegacyStyleInterpolation.cpp:10: ..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration of anonymous class must be a definition class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue { ^ ..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration does not declare anything [-Werror,-Wmissing-declarations] class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue { ^ ..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(78,47) : error: base class has incomplete type class CSSBasicShapeCircleValue final : public CSSBasicShapeValue { ~~~~~~~^~~~~~~~~~~~~~~~~~ BUG=82385 R=sigbjornf@opera.com Committed: https://chromium.googlesource.com/chromium/src/+/3442a5559a27b3ba64a277d5171b89f005a2f5db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSBasicShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 3 months ago (2015-09-24 14:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363363002/1
5 years, 3 months ago (2015-09-24 14:36:06 UTC) #4
sof
lgtm, thanks for the fix & explanation.
5 years, 3 months ago (2015-09-24 14:38:18 UTC) #5
Nico
Thanks! Updated CL description with a link to the clang bug (and removed the TBR ...
5 years, 3 months ago (2015-09-24 14:41:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3442a5559a27b3ba64a277d5171b89f005a2f5db Cr-Commit-Position: refs/heads/master@{#350563}
5 years, 3 months ago (2015-09-24 15:46:18 UTC) #7
Nico
5 years, 3 months ago (2015-09-24 15:46:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3442a5559a27b3ba64a277d5171b89f005a2f5db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698