Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1363343002: Remove the IntentReceiverActivity task when needed. (Closed)

Created:
5 years, 2 months ago by etiennej
Modified:
5 years, 2 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the IntentReceiverActivity task when needed. When started, IntentReceiverActivity may create a new task (e.g.: no ViewportActivity is currently started). In that case, we should both terminate the activity and the task. R=qsr@chromium.org, qsr BUG= Committed: https://chromium.googlesource.com/external/mojo/+/27340925d4c8a717d932f647f0ea6079a3ef2959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M shell/android/apk/src/org/chromium/mojo/shell/IntentReceiverActivity.java View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
etiennej
5 years, 2 months ago (2015-09-24 13:33:58 UTC) #1
qsr
lgtm
5 years, 2 months ago (2015-09-24 13:39:33 UTC) #2
etiennej
5 years, 2 months ago (2015-09-24 13:40:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27340925d4c8a717d932f647f0ea6079a3ef2959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698