MIPS: Specialize FixedTypedArray<> set and get functions to solve unaligned double access.

MIPS: Specialize FixedTypedArray<> set and get functions to solve unaligned double access.

BUG=
TEST=test-api/FixedFloat64Array

[Dmitry Lomov (no reviews), 2014-01-30 16:55:21]

Just a small comment

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3684
src/objects-inl.h:3684: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index));
I am not too happy with using SizeFor here - it does not convey the intent,
although it does do the right thing. Could you add an ElementOffset function to
FixedTypedArray, and use it here?

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3702
src/objects-inl.h:3702: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index), value);
Ditto

[kilvadyb, 2014-01-30 18:27:04]

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3684
src/objects-inl.h:3684: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index));
On 2014/01/30 16:55:22, Dmitry Lomov (chromium) wrote:
> I am not too happy with using SizeFor here - it does not convey the intent,
> although it does do the right thing. Could you add an ElementOffset function
to
> FixedTypedArray, and use it here?

Done.

https://codereview.chromium.org/136333011/diff/1/src/objects-inl.h#newcode3702
src/objects-inl.h:3702: this,
FixedTypedArray<Float64ArrayTraits>::SizeFor(index), value);
On 2014/01/30 16:55:22, Dmitry Lomov (chromium) wrote:
> Ditto

Done.

[Dmitry Lomov (no reviews), 2014-01-30 18:34:03]

A small nit

https://codereview.chromium.org/136333011/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/136333011/diff/20001/src/objects.h#newcode4903
src/objects.h:4903: return SizeFor(index);
Please express them the other way round, i.e. SizeFor(index) is
ElementOffset(length). In that way, if we decide in the future to stick more
stuff at the end of FixedTypedArray, ElementOffset won't be affected.

[Dmitry Lomov (no reviews), 2014-01-30 18:34:42]

On 2014/01/30 18:34:03, Dmitry Lomov (chromium) wrote:
> A small nit
> 
> https://codereview.chromium.org/136333011/diff/20001/src/objects.h
> File src/objects.h (right):
> 
> https://codereview.chromium.org/136333011/diff/20001/src/objects.h#newcode4903
> src/objects.h:4903: return SizeFor(index);
> Please express them the other way round, i.e. SizeFor(index) is

meanint SizeFor(length) of course. 

> ElementOffset(length). In that way, if we decide in the future to stick more
> stuff at the end of FixedTypedArray, ElementOffset won't be affected.

[kilvadyb, 2014-01-30 19:24:52]

https://codereview.chromium.org/136333011/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/136333011/diff/20001/src/objects.h#newcode4903
src/objects.h:4903: return SizeFor(index);
On 2014/01/30 18:34:03, Dmitry Lomov (chromium) wrote:
> Please express them the other way round, i.e. SizeFor(index) is
> ElementOffset(length). In that way, if we decide in the future to stick more
> stuff at the end of FixedTypedArray, ElementOffset won't be affected.

Done.

[Dmitry Lomov (no reviews), 2014-01-30 19:26:34]

lgtm

[Paul Lind, 2014-01-30 20:06:57]

Committed as r18965.