Issue 136333010: git_cl format: allow WebKit style to be picked up from .clang-format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136333010: git_cl format: allow WebKit style to be picked up from .clang-format (Closed)

Created:
6 years, 11 months ago by ncarter (slow)

Modified:
6 years, 11 months ago

Reviewers:
Nico, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, enne (OOO)

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

git_cl format: allow WebKit style to be picked up from .clang-format BUG=240309 TEST='git cl format' and 'git cl format --full' indent by 4 when run inside of third_party/WebKit TBR=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245694

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	git_cl.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

Now that WebKit has a .clang-format file, we should allow it to take effect.

6 years, 11 months ago (2014-01-18 00:52:25 UTC) #1

Nico

lgtm, thanks! I think this is simple enough that you can TBR=iannucci (who will be ...

6 years, 11 months ago (2014-01-18 00:55:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/136333010/1

6 years, 11 months ago (2014-01-18 01:06:38 UTC) #3

iannucci

6 years, 11 months ago (2014-01-18 01:13:36 UTC) #5

Message was sent while issue was closed.

On 2014/01/18 00:55:15, Nico wrote:
> lgtm, thanks!
> 
> I think this is simple enough that you can TBR=iannucci (who will be happy
this
> feature is slightly less chromium-specific :-) )

Yay! I am happy that this feature is less chromium-specific! :D

lgtm

Expand Messages | Collapse Messages