Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 136333007: DevTools: Implement evaluation on async call frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/JavaScriptCallFrame.h
diff --git a/Source/core/inspector/JavaScriptCallFrame.h b/Source/core/inspector/JavaScriptCallFrame.h
index ac0c0350b614765836a3ed44520132f39c979e42..8ad7a335f93f42e2b3845be83dd2fc490015b6c9 100644
--- a/Source/core/inspector/JavaScriptCallFrame.h
+++ b/Source/core/inspector/JavaScriptCallFrame.h
@@ -31,7 +31,6 @@
#ifndef JavaScriptCallFrame_h
#define JavaScriptCallFrame_h
-
#include "bindings/v8/ScopedPersistent.h"
#include "bindings/v8/ScriptWrappable.h"
#include <v8-debug.h>
@@ -64,7 +63,8 @@ public:
bool isAtReturn() const;
v8::Handle<v8::Value> returnValue() const;
- v8::Handle<v8::Value> evaluate(const String& expression);
+ ScriptValue evaluate(const String& expression, const ScriptValue& contextExtension);
+ ScriptValue evaluateGlobal(const String& expression, const ScriptValue& contextExtension);
v8::Handle<v8::Value> restart();
ScriptValue setVariableValue(int scopeNumber, const String& variableName, const ScriptValue& newValue);
v8::Handle<v8::Object> innerCallFrame();
@@ -72,6 +72,8 @@ public:
private:
JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8::Object> callFrame);
+ ScriptValue runEvaluate(const char* methodName, const String& expression, const ScriptValue& contextExtension);
+
v8::Isolate* m_isolate;
RefPtr<JavaScriptCallFrame> m_caller;
ScopedPersistent<v8::Context> m_debuggerContext;

Powered by Google App Engine
This is Rietveld 408576698