Part of multiprofile implementation.

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 
 #include <list>
@@ skipping 45 matching lines @@
 
   // DEPRECATED: DO NOT USE unless in ChromeOS.
   // Same as instance method but provides the default user_data_dir as well.
   static Profile* GetDefaultProfile();
 
   // DEPRECATED: DO NOT USE unless in ChromeOS.
   // Same as GetDefaultProfile() but returns OffTheRecord profile
   // if guest login.
   static Profile* GetDefaultProfileOrOffTheRecord();
 
+#if defined(OS_CHROMEOS)
+  // Returns OffTheRecord profile for usign during signing phase.

[Nikita (slow), 2013/04/04 12:59:13]

nit: Returns OffTheRecord profile used during user authentication phase.

+  Profile* GetSigninProfile(const base::FilePath& user_data_dir);

[sail, 2013/04/04 14:38:37]

Can we keep this out of ProfileManager? Maybe put this in sign-in specific code?

[Nikita (slow), 2013/04/04 14:50:05]

I think that we could  not get this code out of ProfileManager.

[user_data_dir]/Default is a special type of profile only on Chrome OS - it is
used as a part of sign in flow.

On the other hand it should be part of ProfileManager bookkeeping logic like
loading profile, deleting it etc.

[sail, 2013/04/04 15:09:34]

Currently profile manager is a very very large class and it's hard to maintain.
There's nothing that this function needs to do that requires any private data.
If you really can't find a better place to put it then how about doing something
like this:
  profile_signin_util.h
    namespace profile_signin_util {
      GetSigninProfile()
    }

[dzhioev (left Google), 2013/04/04 15:54:41]

* I'm not sure that we can implement GetSigninProfile using only public methods
of ProfileManager.
* We want to eliminate GetDefaultProfile completely while making multiprofiles
and I think Chrome OS related logic should become much simpler.

+
+  // Returns OffTheRecord profile for usign during signing phase.

[Nikita (slow), 2013/04/04 12:59:13]

nit: Drop second comment, place both methods one after another.

+  static Profile* GetSigninProfile();
+#endif
+
   // Returns a profile for a specific profile directory within the user data
   // dir. This will return an existing profile it had already been created,
   // otherwise it will create and manage it.
   Profile* GetProfile(const base::FilePath& profile_dir);
 
   // Returns total number of profiles available on this machine.
   size_t GetNumberOfProfiles();
 
   // Explicit asynchronous creation of a profile located at |profile_path|.
   // If the profile has already been created then callback is called
@@ skipping 285 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
 
  protected:
   virtual void DoFinalInitForServices(Profile*, bool) OVERRIDE {}
   virtual void DoFinalInitLogging(Profile*) OVERRIDE {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_