Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1363293002: JSObject::GetEnumProperty cleanup (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

JSObject::GetEnumProperty cleanup BUG= Committed: https://crrev.com/a00d47c802f93cf9835eafce4c9da2dd10b44f6a Cr-Commit-Position: refs/heads/master@{#30946} Committed: https://crrev.com/4988e42ef7862515461b2b4d9b205e7025048b50 Cr-Commit-Position: refs/heads/master@{#31018}

Patch Set 1 #

Patch Set 2 : merging #

Patch Set 3 : handlifying method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -92 lines) Patch
M src/field-index-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +95 lines, -87 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Camillo Bruni
PTAL - factoring out a branch into a single method - pushing the details of ...
5 years, 3 months ago (2015-09-24 12:20:33 UTC) #2
Camillo Bruni
PTAL - factoring out a branch into a single method - pushing the details of ...
5 years, 3 months ago (2015-09-24 12:20:34 UTC) #3
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-25 08:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363293002/1
5 years, 2 months ago (2015-09-25 13:46:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10077)
5 years, 2 months ago (2015-09-25 13:47:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363293002/20001
5 years, 2 months ago (2015-09-25 14:51:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 15:27:36 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a00d47c802f93cf9835eafce4c9da2dd10b44f6a Cr-Commit-Position: refs/heads/master@{#30946}
5 years, 2 months ago (2015-09-25 15:27:55 UTC) #13
vogelheim
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1371673004/ by vogelheim@chromium.org. ...
5 years, 2 months ago (2015-09-25 17:21:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363293002/40001
5 years, 2 months ago (2015-09-30 12:25:05 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-30 12:49:12 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 12:49:38 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4988e42ef7862515461b2b4d9b205e7025048b50
Cr-Commit-Position: refs/heads/master@{#31018}

Powered by Google App Engine
This is Rietveld 408576698