components/variations/service/variations_service_client.h - Issue 1363243004: Allow embedders to share code to override UI strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service_client.h

Issue 1363243004: Allow embedders to share code to override UI strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to test and class and fix typo Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/variations/service/variations_service.cc ('k') | components/variations/service/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/service/variations_service_client.h

diff --git a/components/variations/service/variations_service_client.h b/components/variations/service/variations_service_client.h

index 2cd26c832963499f4d8b4a3d40f3ff791c8c3b2f..b3758a64b37bdd3eaf3509b0f0b5ce49214e3f9f 100644

--- a/components/variations/service/variations_service_client.h

+++ b/components/variations/service/variations_service_client.h

@@ -57,11 +57,6 @@ class VariationsServiceClient {

// parameter if true is returned.

virtual bool OverridesRestrictParameter(std::string* parameter) = 0;

- // Allows the embedder to override the string resource specified by |hash|

- // with |string| in the resource bundle if desired.

- virtual void OverrideUIString(uint32_t hash,

- const base::string16& string) = 0;

// Called from VariationsService::PerformPreMainMessageLoopStartup().

virtual void OnInitialStartup() {}

};