Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: chrome/browser/metrics/variations/chrome_variations_service_client.cc

Issue 1363243004: Allow embedders to share code to override UI strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to test and class and fix typo Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/chrome_variations_service_client.cc
diff --git a/chrome/browser/metrics/variations/chrome_variations_service_client.cc b/chrome/browser/metrics/variations/chrome_variations_service_client.cc
index 68a6576439eede65c372d1def7b9a5196a3052cd..ed7ceffdba0e273151e35caf42758040de6e4853 100644
--- a/chrome/browser/metrics/variations/chrome_variations_service_client.cc
+++ b/chrome/browser/metrics/variations/chrome_variations_service_client.cc
@@ -6,11 +6,9 @@
#include "base/bind.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/metrics/variations/generated_resources_map.h"
#include "chrome/common/channel_info.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/browser_thread.h"
-#include "ui/base/resource/resource_bundle.h"
#if !defined(OS_ANDROID) && !defined(OS_IOS) && !defined(OS_CHROMEOS)
#include "chrome/browser/upgrade_detector_impl.h"
@@ -81,17 +79,6 @@ bool ChromeVariationsServiceClient::OverridesRestrictParameter(
#endif
}
-void ChromeVariationsServiceClient::OverrideUIString(
- uint32_t hash,
- const base::string16& string) {
- int resource_id = chrome_variations::GetResourceIndex(hash);
- if (resource_id == -1)
- return;
-
- ui::ResourceBundle::GetSharedInstance().OverrideLocaleStringResource(
- resource_id, string);
-}
-
void ChromeVariationsServiceClient::OnInitialStartup() {
#if defined(OS_WIN)
StartGoogleUpdateRegistrySync();

Powered by Google App Engine
This is Rietveld 408576698