chrome/browser/metrics/variations/chrome_variations_service_client.h - Issue 1363243004: Allow embedders to share code to override UI strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/chrome_variations_service_client.h

Issue 1363243004: Allow embedders to share code to override UI strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments by asvitkine Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/metrics_services_manager.cc ('k') | chrome/browser/metrics/variations/chrome_variations_service_client.cc » ('j') | chrome/browser/metrics/variations/ui_string_overrider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/chrome_variations_service_client.h

diff --git a/chrome/browser/metrics/variations/chrome_variations_service_client.h b/chrome/browser/metrics/variations/chrome_variations_service_client.h

index b3b7846679b7ff08265a98942ada9527e8715565..8abe72ef7697f13a361ed9b8b326784733065f56 100644

--- a/chrome/browser/metrics/variations/chrome_variations_service_client.h

+++ b/chrome/browser/metrics/variations/chrome_variations_service_client.h

@@ -29,7 +29,6 @@ class ChromeVariationsServiceClient

network_time::NetworkTimeTracker* GetNetworkTimeTracker() override;

version_info::Channel GetChannel() override;

bool OverridesRestrictParameter(std::string* parameter) override;

- void OverrideUIString(uint32_t hash, const base::string16& string) override;

void OnInitialStartup() override;

private: