Chromium Code Reviews| Index: chrome/browser/metrics/variations/ui_string_overrider_unittest.cc |
| diff --git a/chrome/browser/metrics/variations/generated_resources_map_lookup_unittest.cc b/chrome/browser/metrics/variations/ui_string_overrider_unittest.cc |
| similarity index 58% |
| rename from chrome/browser/metrics/variations/generated_resources_map_lookup_unittest.cc |
| rename to chrome/browser/metrics/variations/ui_string_overrider_unittest.cc |
| index a97f1f6cf5db2d3247e0fbe26af7825516ec7c38..d2acbd8862b2e9d106651c9f1908e94fe7bf546f 100644 |
| --- a/chrome/browser/metrics/variations/generated_resources_map_lookup_unittest.cc |
| +++ b/chrome/browser/metrics/variations/ui_string_overrider_unittest.cc |
| @@ -2,13 +2,29 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#include "chrome/browser/metrics/variations/generated_resources_map.h" |
| +#include "components/variations/service/ui_string_overrider.h" |
| +#include "chrome/browser/metrics/variations/generated_resources_map.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| namespace chrome_variations { |
| -TEST(GeneratedResourcesMapLookupTest, LookupNotFound) { |
| +class UIStringOverriderTest : public ::testing::Test { |
| + public: |
| + UIStringOverriderTest() |
| + : provider_(kResourceHashes, kResourceIndices, kNumResources) {} |
|
Alexei Svitkine (slow)
2015/09/24 21:51:23
Nit: This formatting doesn't seem right. git cl fo
sdefresne
2015/09/28 08:57:32
Acknowledged and fixed.
|
| + |
| + int GetResourceIndex(uint32_t hash) { |
| + return provider_.GetResourceIndex(hash); |
| + } |
| + |
| + private: |
| + variations::UIStringOverrider provider_; |
| + |
| + DISALLOW_COPY_AND_ASSIGN(UIStringOverriderTest); |
| +}; |
| + |
| +TEST_F(UIStringOverriderTest, LookupNotFound) { |
| EXPECT_EQ(-1, GetResourceIndex(0)); |
| EXPECT_EQ(-1, GetResourceIndex(kResourceHashes[kNumResources - 1] + 1)); |
| @@ -17,7 +33,7 @@ TEST(GeneratedResourcesMapLookupTest, LookupNotFound) { |
| EXPECT_EQ(-1, GetResourceIndex(13257681U)); |
| } |
| -TEST(GeneratedResourcesMapLookupTest, LookupFound) { |
| +TEST_F(UIStringOverriderTest, LookupFound) { |
| for (size_t i = 0; i < kNumResources; ++i) |
| EXPECT_EQ(kResourceIndices[i], GetResourceIndex(kResourceHashes[i])); |
| } |