third_party/WebKit/Source/core/css/CSSImageValue.cpp - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mac and Windows tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/custom/marker-getPropertyValue-expected.txt ('K') | « third_party/WebKit/LayoutTests/transitions/svg-transitions-expected.txt ('k') | third_party/WebKit/Source/core/css/CSSMarkup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

index dfcdb3f6b11dd54bdf5374f25d2fceb053d00793..d8cc8958b96d803b005e4ed78d3d55888ee28122 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

@@ -108,8 +108,7 @@ bool CSSImageValue::equals(const CSSImageValue& other) const

String CSSImageValue::customCSSText() const

{

- // TODO(nainar): Serialise with quotation marks to match spec: https://drafts.csswg.org/cssom/#serialize-a-url

- return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";

+ return serializeURI(m_relativeURL);

}

bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const