third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mac and Windows tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property.js ('k') | third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html » ('j') | third_party/WebKit/LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js

diff --git a/third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js b/third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js

index 6c5087b114040e3dbd520e60cf1aef4d6b47f14b..e8a76c9fbb2697280354655a67419122356ac8c3 100644

--- a/third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js

+++ b/third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js

@@ -24,10 +24,10 @@ function testFilterRule(description, rule, expectedValue)

shouldBeEqualToString("declaration.getPropertyValue('-webkit-filter')", expectedValue);

}

-testFilterRule("Basic reference", "url('#a')", "url('#a')");

-testFilterRule("Bare unquoted reference converting to quoted form", "url(#a)", "url('#a')");

-testFilterRule("Multiple references", "url('#a') url('#b')", "url('#a') url('#b')");

-testFilterRule("Reference as 2nd value", "grayscale(1) url('#a')", "grayscale(1) url('#a')");

+testFilterRule("Basic reference", "url('#a')", "url(\"#a\")");

+testFilterRule("Bare unquoted reference converting to quoted form", "url(#a)", "url(\"#a\")");

+testFilterRule("Multiple references", "url('#a') url('#b')", "url(\"#a\") url(\"#b\")");

+testFilterRule("Reference as 2nd value", "grayscale(1) url('#a')", "grayscale(1) url(\"#a\")");

testFilterRule("Integer value", "grayscale(1)");

testFilterRule("Percentage value", "grayscale(50%)");

testFilterRule("Float value converts to integer", "grayscale(1.0)", "grayscale(1)");