third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CSSPrimitiveValue and CSSSVGDocumentValue customCSSText changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html ('K') | « third_party/WebKit/Source/core/css/CSSMarkup.cpp ('k') | third_party/WebKit/Source/core/css/CSSSVGDocumentValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

index f862828c1ff50e89566563ea50ef2a67a3804bf3..5dadf815b6847b264a0360c5bb0d9c7fa2fc2e6e 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

@@ -912,7 +912,7 @@ String CSSPrimitiveValue::customCSSText() const

break;

}

case UnitType::URI:

- text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ")";

+ text = serializeURI(m_value.string);

break;

case UnitType::ValueID:

text = valueName(m_value.valueID);