Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CSSPrimitiveValue and CSSSVGDocumentValue customCSSText changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html
diff --git a/third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html b/third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html
index c0072e1d9eae0350710453615ace2d94b29d81df..d828c713d8a54a2caea343c37a356718a1d6cbfd 100644
--- a/third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html
+++ b/third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html
@@ -14,10 +14,10 @@ function makeCursorRule(rule)
return "cursor: " + rule + ";";
}
-function testCursorRule(rule)
+function testCursorRule(rule, expected)
{
var cssText = makeCursorRule(rule);
- shouldBeEqualToString('roundtripCssRule("' + cssText + '")', cssText);
+ shouldBeEqualToString('roundtripCssRule("' + cssText + '")', makeCursorRule(expected));
}
function testInvalidCursorRule(rule)
@@ -36,26 +36,26 @@ function roundtripCssRule(cssText)
}
// Note that any absolute URL will suffice for these tests (can't use relative URLs
-// since they'll be converted to absolute form in the output). I chose file URLs just
+// since they'll be converted to absolute form in the output). I chosefile URLs just
// to avoid triggering any network activity.
debug('Test a bunch of cursor rules which should round-trip exactly.');
-testCursorRule('auto');
-testCursorRule('none');
-testCursorRule('copy');
-testCursorRule('zoom-in');
-testCursorRule('zoom-out');
-testCursorRule('-webkit-grabbing');
-testCursorRule('-webkit-zoom-in');
-testCursorRule('-webkit-zoom-out');
-testCursorRule('url(file:///foo.png), crosshair');
-testCursorRule('url(file:///foo.png), url(file:///foo2.png), pointer');
-testCursorRule('url(file:///foo.png) 12 3, pointer');
-testCursorRule('url(file:///foo.png) 0 0, pointer');
-testCursorRule('url(file:///foo.png) 12 3, url(file:///foo2.png), url(file:///foo3.png) 6 7, crosshair');
-testCursorRule('url(file:///foo.png) -2 3, pointer');
-testCursorRule('url(file:///foo.png) 2 -3, pointer');
-testCursorRule('url(file:///foo.png) -1 -1, pointer');
+testCursorRule('auto', 'auto');
+testCursorRule('none', 'none');
+testCursorRule('copy', 'copy');
+testCursorRule('zoom-in', 'zoom-in');
+testCursorRule('zoom-out', 'zoom-out');
+testCursorRule('-webkit-grabbing', '-webkit-grabbing');
+testCursorRule('-webkit-zoom-in', '-webkit-zoom-in');
+testCursorRule('-webkit-zoom-out', '-webkit-zoom-out');
+testCursorRule('url(file:///foo.png), crosshair', 'url("file:///foo.png"), crosshair');
Timothy Loh 2015/09/24 07:53:21 just add quotes in the first argument instead of a
nainar 2015/09/25 04:10:18 Done.
+testCursorRule('url(file:///foo.png), url(file:///foo2.png), pointer', 'url("file:///foo.png"), url("file:///foo2.png"), pointer');
+testCursorRule('url(file:///foo.png) 12 3, pointer', 'url("file:///foo.png") 12 3, pointer');
+testCursorRule('url(file:///foo.png) 0 0, pointer', 'url("file:///foo.png") 0 0, pointer');
+testCursorRule('url(file:///foo.png) 12 3, url(file:///foo2.png), url(file:///foo3.png) 6 7, crosshair', 'url("file:///foo.png") 12 3, url("file:///foo2.png"), url("file:///foo3.png") 6 7, crosshair');
+testCursorRule('url(file:///foo.png) -2 3, pointer', 'url("file:///foo.png") -2 3, pointer');
+testCursorRule('url(file:///foo.png) 2 -3, pointer', 'url("file:///foo.png") 2 -3, pointer');
+testCursorRule('url(file:///foo.png) -1 -1, pointer', 'url("file:///foo.png") -1 -1, pointer');
debug('');
debug('Test a bunch of invalid cursor rules which shouldn\'t parse at all.');

Powered by Google App Engine
This is Rietveld 408576698