Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix interpolation tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp
index dfcdb3f6b11dd54bdf5374f25d2fceb053d00793..d8cc8958b96d803b005e4ed78d3d55888ee28122 100644
--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp
@@ -108,8 +108,7 @@ bool CSSImageValue::equals(const CSSImageValue& other) const
String CSSImageValue::customCSSText() const
{
- // TODO(nainar): Serialise with quotation marks to match spec: https://drafts.csswg.org/cssom/#serialize-a-url
- return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";
+ return serializeURI(m_relativeURL);
}
bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const

Powered by Google App Engine
This is Rietveld 408576698