third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix interpolation tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/inspector-support/cssURLQuotes-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/masking/parsing-clip-path-iri.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js

diff --git a/third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js b/third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js

index 27ea17d143abaad3f1cd1f0b9144dee27b9b2804..b6fafdcc7bccce77684cb79a1204d9221e85bddd 100644

--- a/third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js

+++ b/third_party/WebKit/LayoutTests/fast/js/resources/image-preload-helper.js

@@ -13,7 +13,7 @@ function preloadImagesFromStyle(rootNode, imageCount, onComplete, failPattern) {

var imagesToLoad = [];

var seenUrls = {};

for (var i = 0; i < nodes.length; i++) {

- var urls = nodes[i].style.cssText.split(/url\w*\(([^)]*)\)/);

+ var urls = nodes[i].style.cssText.split(/url\w*\("([^)]*)"\)/);

for (var j = 1; j < urls.length; j += 2) {

// Attempt to convert URL to a relative path in order to have deterministic error messages.

var url = urls[j];