third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove decodeURIComponent Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/interpolation/filter-interpolation-expected.txt ('k') | third_party/WebKit/LayoutTests/animations/responsive/fill-responsive.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js

diff --git a/third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js b/third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js

index 19ce36406b93906c3528d22a15ab209181b53c3b..f27b017a69c15f25a7d4d415cca1c6373939de7a 100644

--- a/third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js

+++ b/third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js

@@ -210,7 +210,7 @@

var matches = value.match(/url\([^\)]*\)/g);

Timothy Loh 2015/09/28 06:18:13 should update this too

nainar 2015/09/28 07:22:54 Done.

if (matches !== null) {

for (var i = 0; i < matches.length; ++i) {

- var url = /url\(([^\)]*)\)/g.exec(matches[i])[1];

+ var url = /url\(("|')([^\)]*)('|")\)/g.exec(matches[i])[2];

Timothy Loh 2015/09/28 06:18:13 does this work with just "? Otherwise it'd be bett

nainar 2015/09/28 07:22:54 Done.

anchor.href = url;

anchor.pathname = '...' + anchor.pathname.substring(anchor.pathname.lastIndexOf('/'));

value = value.replace(matches[i], 'url(' + anchor.href + ')');