third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html - Issue 1363233003: Make sure <url>s are being serialized according to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Layout test readability Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js ('K') | « third_party/WebKit/LayoutTests/fast/css/cursor-parsing-quirks-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html » ('j') | third_party/WebKit/LayoutTests/fast/css/script-tests/image-set-parsing.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html

index c35dd05cf04b044fe3d24b45a6b56e977d0622f0..162c85412ff3484886b22857cb4e890337a9336b 100644

--- a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html

+++ b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle-relativeURL.html

@@ -7,8 +7,8 @@

target.style.backgroundImage = "-webkit-cross-fade(url(images1.jpg), url(images2.jpg), 0.5)";

test(function() {

- var expected = "-webkit-cross-fade(url(" + location.href.replace('getComputedStyle-relativeURL.html', 'images1.jpg') + "), url(" + location.href.replace('getComputedStyle-relativeURL.html', 'images2.jpg') + "), 0.5)";

+ var expected = "-webkit-cross-fade(url(\"" + location.href.replace('getComputedStyle-relativeURL.html', 'images1.jpg') + "\"), url(\"" + location.href.replace('getComputedStyle-relativeURL.html', 'images2.jpg') + "\"), 0.5)";

Timothy Loh 2015/09/25 14:22:05 single quotes for this file too

nainar 2015/09/28 01:19:17 Done.

assert_equals(getComputedStyle(target).backgroundImage, expected);

- assert_equals(target.style.backgroundImage, "-webkit-cross-fade(url(images1.jpg), url(images2.jpg), 0.5)");

+ assert_equals(target.style.backgroundImage, "-webkit-cross-fade(url(\"images1.jpg\"), url(\"images2.jpg\"), 0.5)");

}, 'Testing that getComputedStyle.backgroundImage returns absolute URLs and style.backgroundImage returns relative URLs');

</script>