Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1363233003: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix interpolation tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 text = formatNumber(m_value.num, unitTypeToString(type())); 890 text = formatNumber(m_value.num, unitTypeToString(type()));
891 break; 891 break;
892 case UnitType::CustomIdentifier: 892 case UnitType::CustomIdentifier:
893 text = quoteCSSStringIfNeeded(m_value.string); 893 text = quoteCSSStringIfNeeded(m_value.string);
894 break; 894 break;
895 case UnitType::String: { 895 case UnitType::String: {
896 text = serializeString(m_value.string); 896 text = serializeString(m_value.string);
897 break; 897 break;
898 } 898 }
899 case UnitType::URI: 899 case UnitType::URI:
900 text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ")"; 900 text = serializeURI(m_value.string);
901 break; 901 break;
902 case UnitType::ValueID: 902 case UnitType::ValueID:
903 text = valueName(m_value.valueID); 903 text = valueName(m_value.valueID);
904 break; 904 break;
905 case UnitType::PropertyID: 905 case UnitType::PropertyID:
906 text = propertyName(m_value.propertyID); 906 text = propertyName(m_value.propertyID);
907 break; 907 break;
908 case UnitType::RGBColor: { 908 case UnitType::RGBColor: {
909 text = Color(m_value.rgbcolor).serializedAsCSSComponentValue(); 909 text = Color(m_value.rgbcolor).serializedAsCSSComponentValue();
910 break; 910 break;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 visitor->trace(m_value.calc); 990 visitor->trace(m_value.calc);
991 break; 991 break;
992 default: 992 default:
993 break; 993 break;
994 } 994 }
995 #endif 995 #endif
996 CSSValue::traceAfterDispatch(visitor); 996 CSSValue::traceAfterDispatch(visitor);
997 } 997 }
998 998
999 } // namespace blink 999 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSMarkup.cpp ('k') | third_party/WebKit/Source/core/css/CSSSVGDocumentValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698