third_party/WebKit/Source/core/css/FontFace.h - Issue 1363233002: Restrict font-family in @font-face to <family-name>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.h

Issue 1363233002: Restrict font-family in @font-face to <family-name> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/fontfaceset-invalid-family-names-expected.txt ('k') | third_party/WebKit/Source/core/css/FontFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFace.h

diff --git a/third_party/WebKit/Source/core/css/FontFace.h b/third_party/WebKit/Source/core/css/FontFace.h

index daf018197eb7fc4d81ef196c2e406f029f0a9439..6365317cb0e3aa650a4495e6c42cc8e974863abe 100644

--- a/third_party/WebKit/Source/core/css/FontFace.h

+++ b/third_party/WebKit/Source/core/css/FontFace.h

@@ -46,7 +46,7 @@

namespace blink {

class CSSFontFace;

-class CSSValueList;

+class CSSPrimitiveValue;

class DOMArrayBuffer;

class DOMArrayBufferView;

class Document;

@@ -125,7 +125,7 @@ private:

void setPropertyFromString(const Document*, const String&, CSSPropertyID, ExceptionState* = 0);

bool setPropertyFromStyle(const StylePropertySet&, CSSPropertyID);

bool setPropertyValue(PassRefPtrWillBeRawPtr<CSSValue>, CSSPropertyID);

- bool setFamilyValue(CSSValueList*);

+ bool setFamilyValue(CSSPrimitiveValue*);

void loadInternal(ExecutionContext*);

ScriptPromise fontStatusPromise(ScriptState*);