Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1363233002: Restrict font-family in @font-face to <family-name> (Closed)

Created:
5 years, 3 months ago by rwlbuis
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict font-family in @font-face to <family-name> Restrict font-family in @font-face to <family-name> by calling consumeFamilyName directly. To make sure no generic-name is being parsed add the test fontfaceset-invalid-family-names.html. Behavior matches FF. BUG=499780 Committed: https://crrev.com/3def4ceee56560151683ce688a9b96cc8a9340af Cr-Commit-Position: refs/heads/master@{#350479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -72 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/fontfaceset-invalid-family-names.html View 1 chunk +66 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/css/fontfaceset-invalid-family-names-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 5 chunks +58 lines, -58 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
rwlbuis
Bringing this patch back post-merge.
5 years, 3 months ago (2015-09-24 03:00:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363233002/1
5 years, 3 months ago (2015-09-24 03:01:21 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-24 03:01:30 UTC) #8
Timothy Loh
On 2015/09/24 03:01:30, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 3 months ago (2015-09-24 03:04:04 UTC) #9
rwlbuis
On 2015/09/24 03:04:04, Timothy Loh wrote: > On 2015/09/24 03:01:30, commit-bot: I haz the power ...
5 years, 3 months ago (2015-09-24 03:06:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363233002/1
5 years, 3 months ago (2015-09-24 03:09:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 04:57:32 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3def4ceee56560151683ce688a9b96cc8a9340af Cr-Commit-Position: refs/heads/master@{#350479}
5 years, 3 months ago (2015-09-24 04:59:46 UTC) #14
koppenheffer80
5 years, 3 months ago (2015-09-24 07:08:19 UTC) #16
koppenheffer80
5 years, 3 months ago (2015-09-24 07:08:21 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698