Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1363203003: Make a dictionary that expresses a diff between two json files including AST. (Closed)

Created:
5 years, 3 months ago by shimadaa
Modified:
5 years, 3 months ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Add generate_idl_diff.py This script makes a dictionary that expresses a diff between two json files including AST. The output includes annotations representing diff. See the comment in the script for details. BUG=530402 Committed: https://crrev.com/45d79a80177628745ec9a85736e0f5a39be7b18b Cr-Commit-Position: refs/heads/master@{#350786}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated data structure's example #

Total comments: 1

Patch Set 3 : Modified a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -0 lines) Patch
A third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py View 1 2 1 chunk +184 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (5 generated)
shimadaa
5 years, 3 months ago (2015-09-25 03:53:02 UTC) #2
bashi
LGTM. We reviewed this CL on https://codereview.chromium.org/1329983002/
5 years, 3 months ago (2015-09-25 03:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363203003/1
5 years, 3 months ago (2015-09-25 03:55:14 UTC) #5
Yuki
lgtm https://codereview.chromium.org/1363203003/diff/1/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py File third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py (right): https://codereview.chromium.org/1363203003/diff/1/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py#newcode23 third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py:23: {'InterfaceName': { nit: Better to add 'Name' key ...
5 years, 3 months ago (2015-09-25 03:55:59 UTC) #6
haraken
LGTM Let's add more to the CL description so that others can follow what this ...
5 years, 3 months ago (2015-09-25 03:58:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363203003/1
5 years, 3 months ago (2015-09-25 05:10:00 UTC) #9
shimadaa
Updated data structure's example. Thank you. https://codereview.chromium.org/1363203003/diff/1/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py File third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py (right): https://codereview.chromium.org/1363203003/diff/1/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py#newcode23 third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py:23: {'InterfaceName': { On ...
5 years, 3 months ago (2015-09-25 05:13:25 UTC) #10
Yuki
LGTM As Haraken wrote, more detailed CL description is welcome. https://codereview.chromium.org/1363203003/diff/20001/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py File third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py (right): https://codereview.chromium.org/1363203003/diff/20001/third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py#newcode172 ...
5 years, 3 months ago (2015-09-25 05:16:41 UTC) #11
bashi
Could you update the description so that the first line only has one sentence? --- ...
5 years, 3 months ago (2015-09-25 06:08:44 UTC) #12
shimadaa
5 years, 3 months ago (2015-09-25 06:18:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363203003/40001
5 years, 3 months ago (2015-09-25 06:22:07 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-25 08:18:11 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-25 08:19:02 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/45d79a80177628745ec9a85736e0f5a39be7b18b
Cr-Commit-Position: refs/heads/master@{#350786}

Powered by Google App Engine
This is Rietveld 408576698