chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc ('K') | « chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc ('k') | chrome/browser/ui/views/frame/browser_view_focus_uitest.cc » ('j') | chrome/browser/ui/views/frame/browser_view_focus_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc

diff --git a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc

index 3a9dbdacf39924b4fdbbfbabc410e2a60e50c1db..ca815ec729f5c28aef5f61e03ba5100b3b8d0acb 100644

--- a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc

+++ b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc

@@ -53,6 +53,7 @@ class SelectFileDialogImplKDE : public SelectFileDialogImpl {

protected:

~SelectFileDialogImplKDE() override;

+ void CloseImpl() override;

// BaseShellDialog implementation:

bool IsRunning(gfx::NativeWindow parent_window) const override;

@@ -199,6 +200,10 @@ SelectFileDialogImplKDE::SelectFileDialogImplKDE(

desktop_ == base::nix::DESKTOP_ENVIRONMENT_KDE5);

}

+void SelectFileDialogImplKDE::CloseImpl() {

+ NOTIMPLEMENTED();

SelectFileDialogImplKDE::~SelectFileDialogImplKDE() {

}